-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MPAS-O: bug fixes for KPP nonlocal source term #3056
Conversation
@maltrud, this is a placeholder for the moment. When MPAS-Dev/MPAS-Model#305 is merged, this will show the correct diffs. |
Please point to the github issue reporting these bugs. |
@rljacob i don't think there is an issue--just something @vanroekel and i have been sleuthing out. |
Ok. Usually when someone says a PR "fixes several bugs" we'd like at least one issue summarizing the problem or how it manifested. |
ef76001
to
21af4a2
Compare
PR now points to bug issue. @jonbob, this is ready to merge onto next. |
@rljacob - are you satisfied with the "bug fix" part of this now? |
yes |
) Update MPAS-O: bug fixes for KPP nonlocal source term This PR fixes several bugs in the calculation of the nonlocal source term in KPP. for temperature, we need to subtract off the contribution from thickness fluxes that don't change buoyancy. for salinity, we need to add virtual salinity fluxes that do change buoyancy. These fixes have been tested in E3SM G-cases and behave as expected. Fixes #3102 [non-BFB]
merged to next |
Update MPAS-O: bug fixes for KPP nonlocal source term This PR fixes several bugs in the calculation of the nonlocal source term in KPP. for temperature, we need to subtract off the contribution from thickness fluxes that don't change buoyancy. for salinity, we need to add virtual salinity fluxes that do change buoyancy. These fixes have been tested in E3SM G-cases and behave as expected. Fixes #3102 [non-BFB]
merged to master and expected DIFF's have been blessed -- except for:
|
blessed the DIFF for SMS_Ld2.ne30_oECv3_ICG.A_WCYCL1850S_CMIP6.anvil_intel.allactive-v1cmip6 now that the testing system is downloading the cvmix code again |
…lurm-cpus EAMXX: inside a SLURM job get cpu count from SLURM env var
This PR fixes several bugs in the calculation of the nonlocal source term in KPP. for temperature, we need to subtract off the contribution from thickness fluxes that don't change buoyancy. for salinity, we need to add virtual salinity fluxes that do change buoyancy.
These fixes have been tested in E3SM G-cases and behave as expected.
Fixes #3102
[non-BFB]