Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MPAS-O: bug fixes for KPP nonlocal source term #3056

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

mark-petersen
Copy link
Contributor

@mark-petersen mark-petersen commented Jul 10, 2019

This PR fixes several bugs in the calculation of the nonlocal source term in KPP. for temperature, we need to subtract off the contribution from thickness fluxes that don't change buoyancy. for salinity, we need to add virtual salinity fluxes that do change buoyancy.

These fixes have been tested in E3SM G-cases and behave as expected.

Fixes #3102
[non-BFB]

@mark-petersen mark-petersen added bug mpas-ocean non-BFB PR makes roundoff changes to answers. labels Jul 10, 2019
@mark-petersen mark-petersen requested a review from maltrud July 10, 2019 17:38
@mark-petersen
Copy link
Contributor Author

@maltrud, this is a placeholder for the moment. When MPAS-Dev/MPAS-Model#305 is merged, this will show the correct diffs.

@rljacob rljacob added this to the v2.0alpha milestone Jul 10, 2019
@rljacob
Copy link
Member

rljacob commented Jul 25, 2019

Please point to the github issue reporting these bugs.

@rljacob rljacob added bug fix PR and removed bug labels Jul 25, 2019
@rljacob rljacob removed this from the v2.0alpha milestone Jul 25, 2019
@jonbob jonbob added this to the v2.0alpha milestone Jul 25, 2019
@maltrud
Copy link
Contributor

maltrud commented Jul 25, 2019

@rljacob i don't think there is an issue--just something @vanroekel and i have been sleuthing out.

@rljacob
Copy link
Member

rljacob commented Jul 25, 2019

Ok. Usually when someone says a PR "fixes several bugs" we'd like at least one issue summarizing the problem or how it manifested.

@mark-petersen mark-petersen force-pushed the mark-petersen/ocean/nonlocalBugfixKPP branch from ef76001 to 21af4a2 Compare August 1, 2019 16:14
@mark-petersen
Copy link
Contributor Author

PR now points to bug issue. @jonbob, this is ready to merge onto next.

@jonbob
Copy link
Contributor

jonbob commented Aug 6, 2019

@rljacob - are you satisfied with the "bug fix" part of this now?

@rljacob
Copy link
Member

rljacob commented Aug 6, 2019

yes

jonbob added a commit that referenced this pull request Aug 6, 2019
)

Update MPAS-O: bug fixes for KPP nonlocal source term

This PR fixes several bugs in the calculation of the nonlocal source
term in KPP. for temperature, we need to subtract off the contribution
from thickness fluxes that don't change buoyancy. for salinity, we need
to add virtual salinity fluxes that do change buoyancy.

These fixes have been tested in E3SM G-cases and behave as expected.

Fixes #3102
[non-BFB]
@jonbob
Copy link
Contributor

jonbob commented Aug 6, 2019

merged to next

@jonbob jonbob merged commit 21af4a2 into master Aug 7, 2019
jonbob added a commit that referenced this pull request Aug 7, 2019
Update MPAS-O: bug fixes for KPP nonlocal source term

This PR fixes several bugs in the calculation of the nonlocal source
term in KPP. for temperature, we need to subtract off the contribution
from thickness fluxes that don't change buoyancy. for salinity, we need
to add virtual salinity fluxes that do change buoyancy.

These fixes have been tested in E3SM G-cases and behave as expected.

Fixes #3102
[non-BFB]
@jonbob
Copy link
Contributor

jonbob commented Aug 7, 2019

merged to master and expected DIFF's have been blessed -- except for:

  • SMS_Ld2.ne30_oECv3_ICG.A_WCYCL1850S_CMIP6.anvil_intel.allactive-v1cmip6
    which is failing because of a testing problem downloading the cvmix code (but otherwise
    would have an expected DIFF);
  • SMS_Ld2.ne30_oECv3_ICG.A_WCYCL1850S_CMIP6.cori-knl_intel.allactive-v1cmip6
    which is failing due to machine issues (but otherwise would have an expected DIFF)

@jonbob jonbob deleted the mark-petersen/ocean/nonlocalBugfixKPP branch August 7, 2019 15:11
@jonbob
Copy link
Contributor

jonbob commented Aug 13, 2019

blessed the DIFF for SMS_Ld2.ne30_oECv3_ICG.A_WCYCL1850S_CMIP6.anvil_intel.allactive-v1cmip6 now that the testing system is downloading the cvmix code again

jgfouca pushed a commit that referenced this pull request Nov 7, 2024
…lurm-cpus

EAMXX: inside a SLURM job get cpu count from SLURM env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix PR mpas-ocean non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical mixing bug: nonlocal surface tracer flux term
4 participants