Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical mixing bug: nonlocal surface tracer flux term #3102

Closed
mark-petersen opened this issue Aug 1, 2019 · 1 comment · Fixed by #3056
Closed

Vertical mixing bug: nonlocal surface tracer flux term #3102

mark-petersen opened this issue Aug 1, 2019 · 1 comment · Fixed by #3056
Assignees
@mark-petersen @maltrud
Labels
bug mpas-ocean

Comments

@mark-petersen
Copy link
Contributor

The ocean nonlocal surface tracer flux, used by the KPP vertical mixing scheme, is missing some terms:

  • for temperature, we need to subtract off the contribution from thickness fluxes that don't change buoyancy
  • for salinity, we need to add virtual salinity fluxes that do change buoyancy.
@mark-petersen mark-petersen mentioned this issue Aug 1, 2019
Merged
@mark-petersen
Copy link
Contributor Author

This error has the potential to change the solution, but in practice it did not cause substantial differences.

jonbob added a commit that referenced this issue Aug 6, 2019
@jonbob
Merge branch 'mark-petersen/ocean/nonlocalBugfixKPP' into next (PR #3056
76d79af 
)

Update MPAS-O: bug fixes for KPP nonlocal source term

This PR fixes several bugs in the calculation of the nonlocal source
term in KPP. for temperature, we need to subtract off the contribution
from thickness fluxes that don't change buoyancy. for salinity, we need
to add virtual salinity fluxes that do change buoyancy.

These fixes have been tested in E3SM G-cases and behave as expected.

Fixes #3102
[non-BFB]
jonbob added a commit that referenced this issue Aug 7, 2019
@jonbob
Merge branch 'mark-petersen/ocean/nonlocalBugfixKPP' (PR #3056)
863d44a 
Update MPAS-O: bug fixes for KPP nonlocal source term

This PR fixes several bugs in the calculation of the nonlocal source
term in KPP. for temperature, we need to subtract off the contribution
from thickness fluxes that don't change buoyancy. for salinity, we need
to add virtual salinity fluxes that do change buoyancy.

These fixes have been tested in E3SM G-cases and behave as expected.

Fixes #3102
[non-BFB]
jgfouca pushed a commit that referenced this issue Nov 21, 2024
@bartgol
Merge pull request #3102 from E3SM-Project/bartgol/workflows/fix-eamx…
59a42d3 
…x-workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-petersen mark-petersen

@maltrud maltrud

Labels
bug mpas-ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update MPAS-O: bug fixes for KPP nonlocal source term E3SM-Project/E3SM
2 participants
@mark-petersen @maltrud