Bug fixes from NCAR:dyn(int to real),mem alloc fixes for modal aerosols #297
Conversation
This commit fixes the following bugs reported by NCAR: - All dynamic cores had an int in the denominator of an equation which should be real. - There were memory allocation bugs in modal aerosol files which are fixed. NCAR had a lot of other changes in these files. I took only the changes which relevant to ACME codes. See issues #293 and #292 for more details Fixes #292, Fixes #293 [BFB] AG-331, AG-332
|
Passes acme_developer tests |
|
Balwinder, |
|
Sure. Please let me know if you want me to hold off on merging these to master or any other solution which you prefer. |
|
This merge is already water under the bridge so go ahead and finish it. What would help would be to include me in the conversation when you decide you would like a fix or addition from NCAR (i.e., before moving code). Then, I could tell you if I already have that in my fork. |
|
Ok. Sounds good. I will let you know beforehand if I am going to incorporate any fixes or changes from NCAR into ACME. |
|
@susburrows : If you think you are too busy to integrate this branch, please feel free to assign it to other integrators. |
|
Hi Balwinder, I can do it. Can you let me know if you ran the acme_developer test suite? |
|
Never mind, I see that you mentioned it above. I'll do this one right away. |
Bug fixes from NCAR:dyn(int to real),mem alloc fixes for modal aerosols This commit fixes the following bugs reported by NCAR: - All dynamic cores had an int in the denominator of an equation which should be real. - There were memory allocation bugs in modal aerosol files which are fixed. NCAR had a lot of other changes in these files. I took only the changes which are relevant to ACME codes. See issues #293 and #292 for more details Passes acme_developer tests. Fixes #292, Fixes #293 [BFB] AG-331, AG-332
|
I know, but the title then exceeds 72 characters and the repo hooks won't let me commit it. This is because the branch name is so long. What do you suggest we do? |
|
I don't know but lets discuss on https://acme-climate.atlassian.net/wiki/display/SE/Help%3A+Git+and+GitHub |
|
Since all tests are passing on next, I will merge this to master now. |
…297) Bug fixes from NCAR:dyn(int to real),mem alloc fixes for modal aerosols This commit fixes the following bugs reported by NCAR: All dynamic cores had an int in the denominator of an equation which should be real. There were memory allocation bugs in modal aerosol files which are fixed. NCAR had a lot of other changes in these files. I took only the changes which are relevant to ACME codes. See issues #293 and #292 for more details Fixes #292, Fixes #293 [BFB] AG-331, AG-332
Merge to get #297 into coastal * develop: (78 commits) Fixes byte to string conversion python3 error Add log message for lbc updates Update the descriptions of several initialization options for init case 9 Change default value for config_blend_bdy_terrain to false Change default "lbc" stream's filename template to include minutes and seconds Communicate effective radii for cloud, ice, and snow between MPAS and WSM6 Only access config_pio_stride and config_pio_num_iotasks when necessary Return error from read_stream() when inexact stream time not found Avoid calling mpas_atm_update_bdy_tend whenever config_apply_lbcs = false Fix race condition in file tests when clobber_mode = 'append' or 'overwrite' Remove broken log write of cf1,cf2,cf3 from init_atm_case_gfs When using specified zeta levels, set 'zt' for correct coordinate surface smoothing Introduce early check on whether boundary terrain blending will succeed or not Enable soundings to handle non-existence of config_sounding_interval option Check for a valid vertical grid in init_case 9 (LBC setup case) Update version number to 7.0 Migrate code for modifying relhum into its own function, convert_relhum_wrt_ice Recompute initial RH w.r.t. ice below freezing for consistency with model output Verify that config_apply_lbcs is consistent with values in bdyMaskCell field Verify that the input_interval for the 'lbc_in' stream is not 'none' ...
This commit fixes the following bugs reported by NCAR:
should be real.
fixed. NCAR had a lot of other changes in these files. I took only the
changes which are relevant to ACME codes.
See issues #293 and #292 for more details
Fixes #292, Fixes #293
[BFB]
AG-331, AG-332