Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory allocation errors in aerosol water uptake #292

Closed
singhbalwinder opened this issue Aug 4, 2015 · 0 comments · Fixed by #297
Closed

Memory allocation errors in aerosol water uptake #292

singhbalwinder opened this issue Aug 4, 2015 · 0 comments · Fixed by #297
Assignees

Comments

@singhbalwinder
Copy link
Contributor

Bugfix (reported in cam5_4_03)
components/cam/src/chemistry/utils/modal_aero_wateruptake.F90
There are memory allocation errors in the code to recalculate the aerosol water uptake when doing diagnostic radiation calculations with modal aerosols.

Reported by @cecilehannay
AG-332

@singhbalwinder singhbalwinder self-assigned this Aug 4, 2015
singhbalwinder added a commit that referenced this issue Aug 12, 2015
This commit fixes the following bugs reported by NCAR:
- All dynamic cores had an int in the denominator of an equation which
should be real.
- There were memory allocation bugs in modal aerosol files which are
fixed. NCAR had a lot of other changes in these files. I took only the
changes which relevant to ACME codes.

See issues #293 and #292 for more details

Fixes #292, Fixes #293
[BFB]
AG-331, AG-332
susburrows added a commit that referenced this issue Aug 12, 2015
Bug fixes from NCAR:dyn(int to real),mem alloc fixes for modal aerosols

This commit fixes the following bugs reported by NCAR:

- All dynamic cores had an int in the denominator of an equation which
  should be real.

- There were memory allocation bugs in modal aerosol files which are
  fixed. NCAR had a lot of other changes in these files. I took only
  the changes which are relevant to ACME codes.

See issues #293 and #292 for more details

Passes acme_developer tests.

Fixes #292, Fixes #293
[BFB]
AG-331, AG-332
susburrows added a commit that referenced this issue Aug 13, 2015
…297)

Bug fixes from NCAR:dyn(int to real),mem alloc fixes for modal aerosols

This commit fixes the following bugs reported by NCAR:

All dynamic cores had an int in the denominator of an equation which should be real.
There were memory allocation bugs in modal aerosol files which are fixed. NCAR had a lot of other changes in these files. I took only the changes which are relevant to ACME codes.
See issues #293 and #292 for more details

Fixes #292, Fixes #293
[BFB]
AG-331, AG-332
jonbob added a commit that referenced this issue Jul 1, 2019
…t (PR #3033)

Update mpas-source: COMPASS testing, whitespace, documentation

This PR updates the mpas-source submodule with changes to MPAS-Ocean for some
bfb clean-up:
* Fixes typo in particle file initialization script (MPAS-Dev/MPAS-Model #302)
* Change name coriolis to hadv_coriolis (MPAS-Dev/MPAS-Model #293)
  Note: this is internal variable and module name only, not a flag
* Stream defaults and white space corrections in xml file (MPAS-Dev/MPAS-Model #303)
  Note: does not affect E3SM
* Update README for COMPASS ocean with latest mpas_tools (MPAS-Dev/MPAS-Model #292)
* Update COMPASS for python version of JIGSAW (MPAS-Dev/MPAS-Model #301)

[BFB]
jonbob added a commit that referenced this issue Jul 2, 2019
Update mpas-source: COMPASS testing, whitespace, documentation

This PR updates the mpas-source submodule with changes to MPAS-Ocean for some
bfb clean-up:
* Fixes typo in particle file initialization script (MPAS-Dev/MPAS-Model #302)
* Change name coriolis to hadv_coriolis (MPAS-Dev/MPAS-Model #293)
  Note: this is internal variable and module name only, not a flag
* Stream defaults and white space corrections in xml file (MPAS-Dev/MPAS-Model #303)
  Note: does not affect E3SM
* Update README for COMPASS ocean with latest mpas_tools (MPAS-Dev/MPAS-Model #292)
* Update COMPASS for python version of JIGSAW (MPAS-Dev/MPAS-Model #301)

[BFB]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant