Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in generating baselines #2950

Merged
merged 1 commit into from
May 28, 2019
Merged

Conversation

jgfouca
Copy link
Member

@jgfouca jgfouca commented May 28, 2019

Need to use the base case id when parsing test opts.

[BFB]

Need to use the base case id when parsing test opts.

[BFB]
@jgfouca jgfouca added Scripts bug fix PR BFB PR leaves answers BFB CIME labels May 28, 2019
@jgfouca jgfouca self-assigned this May 28, 2019
jgfouca added a commit that referenced this pull request May 28, 2019
Fix bug in generating baselines

Need to use the base case id when parsing test opts.

[BFB]

* jgfouca/cime/fix_hist_bless:
  Fix bug in generating baselines
@jgfouca jgfouca merged commit 3a50066 into master May 28, 2019
jgfouca added a commit that referenced this pull request May 28, 2019
Fix bug in generating baselines

Need to use the base case id when parsing test opts.

[BFB]

* jgfouca/cime/fix_hist_bless:
  Fix bug in generating baselines
@jgfouca jgfouca deleted the jgfouca/cime/fix_hist_bless branch May 28, 2019 19:09
@jinyuntang
Copy link
Contributor

@jgfouca, is this the reason that I got the following error when I was trying to generate a baseline? May I cherrypick to fix the issue in my branch? Thanks
CIMEError: ERROR: 'SMS_Ld1.hcru_hcru.I1850CRUCLM45CN.cori-knl_intel.G.20190528_202945_x4ds3w' does not look like a CIME test name, expect TESTCASE.GRID.COMPSET[.MACHINE_COMPILER[.TESTMODS]]

@jgfouca
Copy link
Member Author

jgfouca commented May 29, 2019

@jinyuntang , yes

jgfouca added a commit to ESMCI/cime that referenced this pull request Jun 12, 2019
…9-06-10

Jgfouca/branch for acme split 2019 06 10

Changes:
* Fix bug in PET timestamp (need to use build as a library, not a subprocess) (E3SM-Project/E3SM#2949)
* Fix bug in generating baselines (Need to use the base case id when parsing test opts.) (E3SM-Project/E3SM#2950)
* Change FFLAGS_NOPT to be an append to the normal set of flags. This reduces duplication with FFLAGS (E3SM-Project/E3SM#2922)
* Add ability to ask for CMake args (get_standard_cmake_args) (E3SM-Project/E3SM#2922)
* CMake macros should NOT be looking at environment, just CMake vars (E3SM-Project/E3SM#2922)
* case_setup will make both macro types (Make and CMake) (E3SM-Project/E3SM#2922)
* Import a FindPetsc CMake module (E3SM-Project/E3SM#2922)
* Implement a more-advanced way of sharing builds within test suites (Implements a concept of build groups within test_scheduler.) (E3SM-Project/E3SM#2961)

Test suite: scripts_regression_tests
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

Code review:
jgfouca pushed a commit that referenced this pull request Jun 25, 2019
make sure optional arg exists before using
Need to make sure optional variable is provided before it is used.

Test suite:
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #2945
User interface changes?:

Update gh-pages html (Y/N)?:

Code review: sacks
jgfouca pushed a commit that referenced this pull request Oct 9, 2024
Automatically Merged using E3SM Pull Request AutoTester
PR Title: move pyscream to nb
PR Author: mahf708
PR LABELS: AT: AUTOMERGE, python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants