Fix bug in PET timestamp #2949
Merged
Fix bug in PET timestamp #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to use build as a library, not a subprocess. [BFB]
|
@singhbalwinder , this should fix your problem. |
jgfouca
added a commit
that referenced
this pull request
May 28, 2019
Fix bug in PET timestamp Need to use build as a library, not a subprocess. [BFB] * jgfouca/cime/fix_pet_timestamp_bug: Fix bug in PET timestamp
jgfouca
added a commit
that referenced
this pull request
May 28, 2019
Fix bug in PET timestamp Need to use build as a library, not a subprocess. [BFB] * jgfouca/cime/fix_pet_timestamp_bug: Fix bug in PET timestamp
|
@jgfouca can you explain how the bug caused the problem? |
|
@rljacob the bug was here: The fact that the build clean was run with run_cmd meant that the window was open for changes to XML files behind the back of the current process. This is why we should always prefer library calls over subprocesses whenever possible. |
jgfouca
added a commit
to ESMCI/cime
that referenced
this pull request
Jun 12, 2019
…9-06-10 Jgfouca/branch for acme split 2019 06 10 Changes: * Fix bug in PET timestamp (need to use build as a library, not a subprocess) (E3SM-Project/E3SM#2949) * Fix bug in generating baselines (Need to use the base case id when parsing test opts.) (E3SM-Project/E3SM#2950) * Change FFLAGS_NOPT to be an append to the normal set of flags. This reduces duplication with FFLAGS (E3SM-Project/E3SM#2922) * Add ability to ask for CMake args (get_standard_cmake_args) (E3SM-Project/E3SM#2922) * CMake macros should NOT be looking at environment, just CMake vars (E3SM-Project/E3SM#2922) * case_setup will make both macro types (Make and CMake) (E3SM-Project/E3SM#2922) * Import a FindPetsc CMake module (E3SM-Project/E3SM#2922) * Implement a more-advanced way of sharing builds within test suites (Implements a concept of build groups within test_scheduler.) (E3SM-Project/E3SM#2961) Test suite: scripts_regression_tests Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing] Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to use build as a library, not a subprocess.
[BFB]