Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add title attributes and other accessibility fixes for map controls #85

Merged
merged 4 commits into from
Mar 20, 2021
Merged

Add title attributes and other accessibility fixes for map controls #85

merged 4 commits into from
Mar 20, 2021

Conversation

komali2
Copy link
Contributor

@komali2 komali2 commented Mar 20, 2021 •
edited
Loading

  1. Switch zoom control title attributes from default English to Mandarin.
  • Because most users are Mandarin speakers
  • TEST: Hover mouse over zoom controls. Ensure proper text displays in popup.
  1. Set the + and - zoom button images to have src attributes
  • To ensure something displays if the image fails to load
  • To improve accessibility
  • TEST: Inspect the + and - images, ensure there is a src attribute with a value that makes sense
  1. Add Title attribute to Location control
  • To ensure a tooltip display
  • To improve accessibility
  • TEST: Hover mouse over Location control, ensure tooltip appears
  1. Add Name attributes to filter buttons
  • To improve accessibility
  • TEST: Inspect map factory filter buttons, ensure they have sensible name attributes

Addresses #84 and #77

komali2 added 4 commits March 20, 2021 12:13
@komali2
Change zoom control titles to use mandarin
741c8ef 
77
@komali2
Set alt tag for + / - images
6a227be 
just in case

77
@komali2
Add title attribute to location button
e7020f7 
So that screen readers can read it

Also so that there is an on:hover message

84
@komali2
Add name attribute to filter buttons to guarantee accessibility
5a7ea64 
Many screen readers will read button contents, but adding a name
ensures this functionality more broadly.
@komali2 komali2 force-pushed the caleb/add-title-to-mapp-zoom branch from dca8b61 to 5a7ea64 Compare March 20, 2021 04:51
@komali2 komali2 requested a review from Yukaii March 20, 2021 04:52
@komali2 komali2 self-assigned this Mar 20, 2021
This was linked to issues Mar 20, 2021
Locaiton button doesn't have Title attribute (no hover text) #84
Closed
四塊均需 hover message #77
Closed
Yukaii
Yukaii approved these changes Mar 20, 2021
View reviewed changes
Copy link
Contributor

@Yukaii Yukaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks @komali2 🤩

@Yukaii Yukaii merged commit 33ce3c7 into master Mar 20, 2021
@Yukaii Yukaii deleted the caleb/add-title-to-mapp-zoom branch March 20, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yukaii Yukaii Yukaii approved these changes

Assignees

@komali2 komali2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Locaiton button doesn't have Title attribute (no hover text) 四塊均需 hover message
2 participants
@komali2 @Yukaii