Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

四塊均需 hover message #77

Closed
jidanni opened this issue Jun 14, 2020 · 7 comments · Fixed by #85
Closed

四塊均需 hover message #77

jidanni opened this issue Jun 14, 2020 · 7 comments · Fixed by #85
Assignees
Labels
a11y good first issue Good for newcomers

Comments

@jidanni
Copy link

jidanni commented Jun 14, 2020

如 "T" 不敢按,因不知是什麼功能。
3453-0
故四塊均需 hoverover message saying what they do, e.g., 放大,縮小…

@jidanni
Copy link
Author

jidanni commented Jun 14, 2020

"T" 即要示「篩選」。

@Yukaii Yukaii transferred this issue from Disfactory/Disfactory Feb 24, 2021
@Yukaii Yukaii added a11y good first issue Good for newcomers labels Feb 24, 2021
@Yukaii
Copy link
Contributor

Yukaii commented Feb 24, 2021

考慮使用 Vuetify 按鈕的 Tooltip 元件 https://vuetifyjs.com/en/components/tooltips/#usage

frontend/src/lib/map.ts

Lines 448 to 454 in f7da19b

new Zoom({
zoomInLabel: mapControlButtons.zoomIn,
zoomOutLabel: mapControlButtons.zoomOut
}),
new ScaleLine(),
new Rotate(),
new Attribution()

因為原本的控制鍵是用 openlayer 做的,所以需要研究 openlayer 的按鈕如何加上 title attribute

@Yukaii
Copy link
Contributor

Yukaii commented Feb 24, 2021

  • 各個按鈕加上 title attribute
  • 確定 attribute 為中文

@Yukaii
Copy link
Contributor

Yukaii commented Mar 20, 2021

Assign to @komali2

@komali2 komali2 self-assigned this Mar 20, 2021
@komali2
Copy link
Contributor

komali2 commented Mar 20, 2021

This was potentially fixed upstream by OM, not sure, in any case, there's a title attribute now, and hover works.

However, it's in English, so I'll submit a PR or at least issue to OM to allow insertion of a custom string, so translated strings can be used.

@komali2 komali2 closed this as completed Mar 20, 2021
@komali2
Copy link
Contributor

komali2 commented Mar 20, 2021

@komali2 komali2 reopened this Mar 20, 2021
@komali2
Copy link
Contributor

komali2 commented Mar 20, 2021

We'll change it to mandarin at least for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants