Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1031: Bloom Filter - Migrated bf.add, bf.reserve, bf.exists & bf.info to store_eval #1117

Merged

Conversation

apoorvyadav1111
Copy link
Contributor

@apoorvyadav1111 apoorvyadav1111 commented Oct 16, 2024

Fixes: #1031 #1110

For migration commands, please consider this a template on how to tackle the issue. I have divided the tasks into smaller goals and made an individual commit.

Condition Return Value
Migrating eval to store eval 7883d48
Modify unit test with new response format 93c2358
Migrate integration tests from async to resp b33cd1d
Add/update integration in websocket /97744b6
Add/update integration in HTTP 3a251d8
Ensure all integration test pass 3a251d8
Update/Add docs for the commands 66dd05e
Lint checks 32216df

Checklist

  • Migrated the evalXXX function with the latest definition
  • Update or add unit tests for the new implementation.
  • All unit tests pass successfully.
  • Ensure all integration tests pass successfully.
  • Move Integration tests for the respective commands under the RESP integration tests directory from the Async directory
  • Please validate that the documentation for the respective commands is up to date. If not then consider adding them.

@apoorvyadav1111 apoorvyadav1111 changed the title Bloom Filter: migrated evalXXX to store_eval #1031: Bloom Filter - migrated evalXXX to store_eval Oct 16, 2024
@apoorvyadav1111 apoorvyadav1111 changed the title #1031: Bloom Filter - migrated evalXXX to store_eval #1031: Bloom Filter - Migrated bf.add, bf.reserve, bf.exists & bf.info to store_eval Oct 17, 2024
@AshwinKul28 AshwinKul28 added the migration -- command Migrates current eval to a refactored eval for all protocols functionality label Oct 18, 2024
@apoorvyadav1111 apoorvyadav1111 force-pushed the migrate/1031-bloom-filter branch from 7494344 to e4a24d9 Compare October 19, 2024 10:58
@apoorvyadav1111 apoorvyadav1111 marked this pull request as ready for review October 22, 2024 17:11
@apoorvyadav1111 apoorvyadav1111 force-pushed the migrate/1031-bloom-filter branch from afb541c to 66dd05e Compare October 22, 2024 17:13
@@ -63,7 +64,7 @@ func TestObjectCommand(t *testing.T) {
},
{
name: "Object Encoding check for bf",
commands: []string{"BFADD bloomkey value1", "BFADD bloomkey value2", "OBJECT ENCODING bloomkey"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove bf tests from async. I see since you have already implemented it in resp we can remove it from here. Or have you just kept it to check that the current functionality is intact?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have kept it here so that it can be migrated when Object commands are migrated.

@AshwinKul28
Copy link
Contributor

Thanks for this PR @apoorvyadav1111 . Fantastic effort. Everything looks good and we can now reuse evalError and evalResponse functions in all store evals. We may not ask others to do the changes again if other PRs are already in the last stage, we will do it by ourselves once all commands are migrated.

Also, I see your commit links are broken in the PR description for now, once it's added to master I believe it should work.

Thanks again. I just have one comment, post resolution of that feel free to merge.

Copy link
Contributor

@AshwinKul28 AshwinKul28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apoorvyadav1111
Copy link
Contributor Author

Hi @AshwinKul28 , thanks for the review. It must be due to force-push, for the safer side, I will update the commits once the branch gets merged and will not be modified.

@apoorvyadav1111 apoorvyadav1111 merged commit 39f5f3a into DiceDB:master Oct 22, 2024
2 checks passed
@apoorvyadav1111
Copy link
Contributor Author

Hi @AshwinKul28 , Apologies I merged it before looking at the new commits, I can definitely raise a new PR right now and add those comments. I have updated the commit hashes for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration -- command Migrates current eval to a refactored eval for all protocols functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command Migration: ('BFINIT', 'BFADD', 'BFEXISTS', 'BFINFO')
2 participants