Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent BF: Bloom Filter commands are inconsistent with Redis output #1110

Closed
apoorvyadav1111 opened this issue Oct 16, 2024 · 2 comments
Assignees
Labels

Comments

@apoorvyadav1111
Copy link
Contributor

apoorvyadav1111 commented Oct 16, 2024

Found while working on #1031

Steps to reproduce

127.0.0.1:7379> bf.add k 1
(integer) 0
127.0.0.1:7379> bf.info k
name: k, error rate: 0.010000, capacity: 1024, total bits reserved: 10344, bits per element: 9.585058, hash functions: 7

Expected output

The expected output when the above set of commands (maybe when run on Redis)

127.0.0.1:6379> bf.info k
 1) Capacity
 2) (integer) 100
 3) Size
 4) (integer) 240
 5) Number of filters
 6) (integer) 1
 7) Number of items inserted
 8) (integer) 1
 9) Expansion rate
10) (integer) 2

Observed output

The observed output when the above set of commands when run on DiceDB

127.0.0.1:7379> bf.info k
name: k, error rate: 0.010000, capacity: 1024, total bits reserved: 10344, bits per element: 9.585058, hash functions: 7

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. addition of relevant test case to ensure we catch the regression

You can find the tests under the integration_tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

@vpsinghg
Copy link
Contributor

@apoorvyadav1111 can I pick this up ?

@apoorvyadav1111
Copy link
Contributor Author

Hi @vpsinghg, Thank you for your interest to close this issue. However, this issue is part of another issue I an assigned to and I created this for tracking purposes.

@apoorvyadav1111 apoorvyadav1111 added the bug Something isn't working label Oct 16, 2024
@apoorvyadav1111 apoorvyadav1111 changed the title Inconsistent BF: Bloom Filter commands are inconsitent with Redis output Inconsistent BF: Bloom Filter commands are inconsistent with Redis output Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants