Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer refactor #315

Merged
merged 17 commits into from
May 9, 2024
Merged

Renderer refactor #315

merged 17 commits into from
May 9, 2024

Conversation

Arcnor
Copy link
Collaborator

@Arcnor Arcnor commented May 8, 2024

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

This is the first of a number of PRs that refactor the renderer to make it easier to port to different APIs. This first chunk of work simply moves all that's not OpenGL specific to a base file.

If we want to allow multiple renderers & dynamic change between them this will need a bigger change to actually use classes (or any other mechanism) for easier overriding of behavior. That said, even without that a proper way of overriding will be needed for renderers that actually need to change the behavior of those base functions I just moved.

Each commit on this PR should compile on its own and should present no changes when ran.

Related Issues

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

@JeodC JeodC requested a review from jmarshall23 May 8, 2024 17:32
@Arcnor Arcnor force-pushed the renderer-refactor branch from 9c5d504 to 860c9e8 Compare May 9, 2024 11:19
Copy link
Member

@Lgt2x Lgt2x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is much more work to do for the renderer to be better organized but that's a good first step! Don't hesitate to create a tracking issue to share your full vision and progress ;)

@Arcnor Arcnor merged commit 1f94e62 into DescentDevelopers:main May 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants