-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renderer refactor #315
Merged
Merged
Renderer refactor #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterheart
reviewed
May 8, 2024
Lgt2x
reviewed
May 9, 2024
Lgt2x
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is much more work to do for the renderer to be better organized but that's a good first step! Don't hesitate to create a tracking issue to share your full vision and progress ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This is the first of a number of PRs that refactor the renderer to make it easier to port to different APIs. This first chunk of work simply moves all that's not OpenGL specific to a base file.
If we want to allow multiple renderers & dynamic change between them this will need a bigger change to actually use classes (or any other mechanism) for easier overriding of behavior. That said, even without that a proper way of overriding will be needed for renderers that actually need to change the behavior of those base functions I just moved.
Each commit on this PR should compile on its own and should present no changes when ran.
Related Issues
Screenshots (if applicable)
Checklist
Additional Comments