POC for trsnaltor for attributes #222
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| // Copyright OpenTelemetry Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package attributes | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "go.opentelemetry.io/collector/component" | ||
| "go.opentelemetry.io/collector/pdata/pcommon" | ||
| "go.opentelemetry.io/otel/attribute" | ||
| "go.opentelemetry.io/otel/metric" | ||
|
|
||
| "github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source" | ||
| ) | ||
|
|
||
| const missingSourceMetricName string = "datadog.otlp_translator.attributes.missing_source" | ||
|
|
||
| // Translator of attributes. | ||
| type Translator struct { | ||
| missingSources metric.Int64Counter | ||
| } | ||
|
|
||
| // NewTranslator returns a new attributes mapper. | ||
| func NewTranslator(set component.TelemetrySettings) (*Translator, error) { | ||
| meter := set.MeterProvider.Meter("github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes") | ||
| missingSources, err := meter.Int64Counter( | ||
| missingSourceMetricName, | ||
| metric.WithDescription("OTLP payloads that are missing a source (e.g. hostname)"), | ||
| metric.WithUnit("[payload]"), | ||
|
There was a problem hiding this comment. may need to change this to |
||
| ) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to build missing source counter: %w", err) | ||
| } | ||
|
|
||
| return &Translator{ | ||
| missingSources: missingSources, | ||
| }, nil | ||
| } | ||
|
|
||
| // MapToSource gets a telemetry signal source from its attributes. | ||
| func (p *Translator) MapToSource(ctx context.Context, attrs pcommon.Map, set attribute.Set) (source.Source, bool) { | ||
|
There was a problem hiding this comment. Seems like the PR is missing the logic to avoid counting |
||
| src, ok := SourceFromAttrs(attrs) | ||
| if !ok { | ||
| p.missingSources.Add(ctx, 1, metric.WithAttributeSet(set)) | ||
| } | ||
|
|
||
| return src, ok | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically we are counting the number of resources without host identifying attributes, rather than attributes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Assuming the logs code gets refactored)