POC for trsnaltor for attributes #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackjmr
reviewed
Dec 14, 2023
| } | ||
|
|
||
| // MapToSource gets a telemetry signal source from its attributes. | ||
| func (p *Translator) MapToSource(ctx context.Context, attrs pcommon.Map, set attribute.Set) (source.Source, bool) { |
There was a problem hiding this comment.
Seems like the PR is missing the logic to avoid counting datadog.otlp_translator.attributes.missing_source ?
| func extractHostNameAndServiceName(resourceAttrs pcommon.Map, logAttrs pcommon.Map) (host string, service string) { | ||
| if src, ok := attributes.SourceFromAttrs(resourceAttrs); ok && src.Kind == source.HostnameKind { | ||
| func (t *Translator) extractHostNameAndServiceName(resourceAttrs pcommon.Map, logAttrs pcommon.Map) (host string, service string) { | ||
| // TODO: This maps the same resource multiple times and generates the metric multiple times :( |
| "github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes/source" | ||
| ) | ||
|
|
||
| const missingSourceMetricName string = "datadog.otlp_translator.attributes.missing_source" |
There was a problem hiding this comment.
Suggested change
| const missingSourceMetricName string = "datadog.otlp_translator.attributes.missing_source" | |
| const missingSourceMetricName string = "datadog.otlp_translator.resources.missing_source" |
Technically we are counting the number of resources without host identifying attributes, rather than attributes ?
There was a problem hiding this comment.
(Assuming the logs code gets refactored)
| missingSources, err := meter.Int64Counter( | ||
| missingSourceMetricName, | ||
| metric.WithDescription("OTLP payloads that are missing a source (e.g. hostname)"), | ||
| metric.WithUnit("[payload]"), |
There was a problem hiding this comment.
may need to change this to {resource} if you agree with the suggestion above. In both cases I believe it needs to be curly braces.
This was referenced Dec 19, 2023
|
Last part in #231, where I addressed all the comments here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation