Correctly handle errors during initialization + code refactor #9626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hithwen
previously requested changes
Jul 5, 2021
ofek
requested changes
Jul 16, 2021
|
|
||
|
|
||
| class LegacyKafkaCheck_0_10_2(AgentCheck): | ||
| class LegacyKafkaCheck_0_10_2(object): |
There was a problem hiding this comment.
I'm not convinced this is a better approach for this case; can you explain your rationale for composition over inheritance?
There was a problem hiding this comment.
- Option 1 is to make LegacyKafkaCheck and NewKafkaCheck both inherit from
KafkaConsumerCheck. This can't be done as the agent refuses to loadKafkaConsumerCheckif it's subclassed anywhere. - Option 2 is to keep a class
KafkaCheckand override the__new__method to return aLegacyKafkaCheckinstance in case a certain condition is found after connecting to Kafka. This is the current situation and it needs to be removed with the refactor. Indeed we can't retry checking that version condition by setting the check as acheck_initialization, once the class is initialized we can't change it. - Option 3 is to make a
KafkaConsumermain class that inherit from AgentCheck and this is the only class that can inherit from it. We then need aNewKafkaConsumerimplementation and aLegacyKafkaCheckimplementation. The common code can now live inKafkaConsumer.
With option 3 there are a few design possibilities, I decided to override the __getattr__ method because of the large number of calls to self.gauge, self.submit_metadata etc. that are happening in many places.
ofek
approved these changes
Jul 20, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2021
* Refactor kafka_consumer * fixup * fixup * Address review 60ac6ae
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.