Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call correct method when sending events #10960

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Call correct method when sending events #10960

merged 2 commits into from
Dec 29, 2021

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Call correct method when sending events

Motivation

It was renamed in #9626 but the usages were not updated

Additional Notes

Investigate checking for this in style validation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@sarah-witt sarah-witt marked this pull request as ready for review December 27, 2021 22:12
@sarah-witt sarah-witt requested a review from a team as a code owner December 27, 2021 22:12
@codecov
Copy link

codecov bot commented Dec 27, 2021 •
edited
Loading

Codecov Report

Merging #10960 (44a0689) into master (f4ba3f5) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Flag Coverage Δ
kafka_consumer 82.66% <75.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ofek
ofek approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@sarah-witt sarah-witt merged commit 22b09e1 into master Dec 29, 2021
@sarah-witt sarah-witt deleted the sarah/call-correct-method branch December 29, 2021 14:19
cswatt pushed a commit that referenced this pull request Jan 5, 2022
@sarah-witt @cswatt
Call correct method when sending events (#10960)
4ce6eb7 
* Call correct method when sending events

* Add simple test for sending events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
integration/kafka_consumer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarah-witt @ofek