Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated description of local_cert_path option #8500

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Remove outdated description of local_cert_path option #8500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28461cf
Remove outdated description of `local_cert_path` option
ofek Jan 31, 2021
0989bf1
Update spec.yaml
ofek Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tls/assets/configuration/spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ files:
description: |
The path to a local certificate in lieu of a server/port. In this mode, the
service checks `tls.can_connect` and `tls.version` are unavailable. The
certificate can be in PEM or DER format. If in DER format, the file
extension must be either `.cer`, `.crt`, or `.der`.
certificate can be in PEM or DER format.
value:
type: string
- name: server_hostname
Expand Down
3 changes: 1 addition & 2 deletions tls/datadog_checks/tls/data/conf.yaml.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ instances:
## @param local_cert_path - string - optional
## The path to a local certificate in lieu of a server/port. In this mode, the
## service checks `tls.can_connect` and `tls.version` are unavailable. The
## certificate can be in PEM or DER format. If in DER format, the file
## extension must be either `.cer`, `.crt`, or `.der`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If in DER format, the file extension must be either .cer, .crt, or .der.

So this is not true anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! As shown in the linked PR

## certificate can be in PEM or DER format.
#
# local_cert_path: <LOCAL_CERT_PATH>

Expand Down