Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated description of local_cert_path option #8500

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jan 31, 2021

Motivation

#5694

@ofek ofek requested review from a team as code owners January 31, 2021 04:34
@ghost ghost added the integration/tls label Jan 31, 2021
@@ -41,8 +41,7 @@ instances:
## @param local_cert_path - string - optional
## The path to a local certificate in lieu of a server/port. In this mode, the
## service checks `tls.can_connect` and `tls.version` are unavailable. The
## certificate can be in PEM or DER format. If in DER format, the file
## extension must be either `.cer`, `.crt`, or `.der`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If in DER format, the file extension must be either .cer, .crt, or .der.

So this is not true anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! As shown in the linked PR

apigirl
apigirl previously approved these changes Feb 1, 2021
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from docs

@ofek ofek merged commit a28fe00 into master Feb 3, 2021
@ofek ofek deleted the ofek-patch-2 branch February 3, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants