Add kube_scheduler config spec #7614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
| bearer_token_auth: true | ||
| # bearer_token_auth: true | ||
|
|
||
| ## @param bearer_token_path - string - optional - default: /var/run/secrets/kubernetes.io/serviceaccount/token |
There was a problem hiding this comment.
Why are we adding those few options here but not others? Should we leave it as it is right now as the auto_conf file is supposed to work out of the box or don't work at all ?
There was a problem hiding this comment.
Primarily to be in sync with kube_apiserver (#7614), though there may be good reasons the options weren't included in this config.
|
We would need to update the base dependency as well like in #7612 (comment) |
FlorianVeaux
approved these changes
Sep 18, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Sep 18, 2020
* Add kube_scheduler config spec * Update base requirement a557d27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates config spec for kube_scheduler
Motivation
See #7605