Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support releasing non-core checks #6805

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Support releasing non-core checks #6805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion datadog_checks_dev/datadog_checks/dev/tooling/commands/release/make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ def make(ctx, checks, version, initial_release, skip_sign, sign_only, exclude):
if initial_release:
version = '1.0.0'

repo_choice = ctx.obj['repo_choice']

# Signing is done by a pipeline in a separate commit
if repo_choice != 'core' and not sign_only:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably missing some background, but why does it make sense to be able to run a make --sign-only on extras?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--sign-only would be used only by the signer bot

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My assumption here is so that the auto-signing bot can leverage ddev directly, correct @ofek ?
Otherwise we would need a separate logic to create the signing JSON files.

skip_sign = True

# Keep track of the list of checks that have been updated.
updated_checks = []
for check in checks:
Expand Down Expand Up @@ -143,7 +149,7 @@ def make(ctx, checks, version, initial_release, skip_sign, sign_only, exclude):
commit_targets = [check]
updated_checks.append(check)
# update the list of integrations to be shipped with the Agent
if check not in NOT_CHECKS:
if repo_choice == 'core' and check not in NOT_CHECKS:
req_file = get_agent_release_requirements()
commit_targets.append(os.path.basename(req_file))
echo_waiting('Updating the Agent requirements file... ', nl=False)
Expand Down