Support releasing non-core checks #6805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
| repo_choice = ctx.obj['repo_choice'] | ||
|
|
||
| # Signing is done by a pipeline in a separate commit | ||
| if repo_choice != 'core' and not sign_only: |
There was a problem hiding this comment.
I'm probably missing some background, but why does it make sense to be able to run a make --sign-only on extras?
There was a problem hiding this comment.
--sign-only would be used only by the signer bot
There was a problem hiding this comment.
My assumption here is so that the auto-signing bot can leverage ddev directly, correct @ofek ?
Otherwise we would need a separate logic to create the signing JSON files.
trishankatdatadog
approved these changes
Jun 3, 2020
This was referenced Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We'll need this soon