Improves tagging compliancy #5105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e3f724 to
13970a6
Compare
89b809f to
c0c308b
Compare
Codecov Report
|
The `kubernetes_state` and `kubernetes` checks were using a different set of tag names to convey the same information. This change aims to introduce the `kubernetes` check tag set in the `kubernetes_state` check. To ease the user migration to the new tag names. This commit also introduces a new parameter `keep_ksm_labels` to have both tag sets on `kubernetes_state` metrics. Currently, `keep_ksm_labels` is set to `True` by default. Add `ignore_listener_tags` in `auto_conf` file to remove the autodiscovery listener tags from the check config.
6cc6f4e to
1765ae5
Compare
hkaj
approved these changes
Nov 28, 2019
hkaj
previously approved these changes
Nov 28, 2019
therve
requested changes
Nov 29, 2019
kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
Outdated
Show resolved
Hide resolved
kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
Outdated
Show resolved
Hide resolved
kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
Outdated
Show resolved
Hide resolved
kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
Outdated
Show resolved
Hide resolved
kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
Outdated
Show resolved
Hide resolved
| Redefine this method to allow labels duplication, during migration phase | ||
| """ | ||
| custom_tags = scraper_config['custom_tags'] | ||
| _tags = list(custom_tags) |
There was a problem hiding this comment.
Doesn't look like it? :). No worries though.
kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
Outdated
Show resolved
Hide resolved
|
@therve thank you for your review, I addressed all your comments. It would be great ff you can do a second review. |
hkaj
reviewed
Nov 29, 2019
kubernetes_state/datadog_checks/kubernetes_state/data/auto_conf.yaml
Outdated
Show resolved
Hide resolved
…f.yaml Co-Authored-By: Haïssam Kaj <hkaj@users.noreply.github.com>
hkaj
approved these changes
Nov 29, 2019
therve
approved these changes
Nov 29, 2019
| Redefine this method to allow labels duplication, during migration phase | ||
| """ | ||
| custom_tags = scraper_config['custom_tags'] | ||
| _tags = list(custom_tags) |
There was a problem hiding this comment.
Doesn't look like it? :). No worries though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change aims to introduce the
kubernetescheck tag set in thekubernetes_statecheck.
To ease the user migration to the new tag names. This commit also introduces a new
parameter
ignore_autodiscovery_tagsto have both tag sets onkubernetes_statemetrics.Currently,
ignore_autodiscovery_tagsis set toTrueby default.Motivation
The
kubernetes_stateandkuberneteschecks were using a different set of tag namesto convey the same information.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached