[autodiscovery] Add ignore_autodiscovery_tags config parameter
#4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaj
reviewed
Nov 28, 2019
releasenotes/notes/autodiscovery-add-ignore_listener_tags-parameter-9968246cdad12bed.yaml
Outdated
Show resolved
Hide resolved
In some cases, a check should not receive tags coming from the autodiscovery listeners. By default `ignore_listener_tags` is set to false which doesn't change the behavior of the checks. The first check that will use it is `kubernetes_state`.
2984786 to
6788551
Compare
remeh
reviewed
Nov 29, 2019
| tags, err := svc.GetTags() | ||
| if err != nil { | ||
| return resolvedConfig, err | ||
| tags := []string{} |
There was a problem hiding this comment.
Instead of having a slice later processed which could be empty in some cases, it may have been cleaner to have:
for i := 0; i < len(resolvedConfig.Instances); i++ {
err = resolvedConfig.Instances[i].MergeAdditionalTags(tags)
if err != nil {
return resolvedConfig, err
}
}
runned only if !tpl.IgnoreListenerTags (moving the svc.GetTags() also there obv).
Something like:
if !tpl.IgnoreListenerTags {
tags, err = svc.GetTags()
if err != nil {
return resolvedConfig, err
}
for i := 0; i < len(resolvedConfig.Instances); i++ {
err = resolvedConfig.Instances[i].MergeAdditionalTags(tags)
if err != nil {
return resolvedConfig, err
}
}
}
This way, all the logic around tags is in the same block in this function. WDYT?
There was a problem hiding this comment.
@remeh let me know if you are ok with my change.
e55c0f6 to
ff0019f
Compare
ff0019f to
9f0ac49
Compare
ignore_listener_tags config parameterignore_autodiscovery_tags config parameter
hkaj
reviewed
Nov 29, 2019
hkaj
reviewed
Nov 29, 2019
Co-Authored-By: Haïssam Kaj <hkaj@users.noreply.github.com>
hkaj
approved these changes
Nov 29, 2019
remeh
approved these changes
Nov 29, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
ignore_autodiscovery_tagsconfig parameter.Motivation
In some cases, a check should not receive tags coming from the autodiscovery listeners.
By default
ignore_autodiscovery_tagsis set to false which didn't change the behavior of the checks.The first check that will use it is
kubernetes_state.Additional Notes
link to this pr: DataDog/integrations-core#5105