Add phase tag to pod metrics #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12b3375 to
aa4f31e
Compare
|
This broke hostname collection, will fix asap. |
Codecov Report
@@ Coverage Diff @@
## master #2624 +/- ##
==========================================
- Coverage 83.89% 76.35% -7.54%
==========================================
Files 638 49 -589
Lines 36323 3612 -32711
Branches 4425 452 -3973
==========================================
- Hits 30472 2758 -27714
+ Misses 4545 738 -3807
+ Partials 1306 116 -1190 |
b2dd492 to
d7d5136
Compare
d7d5136 to
9b09f18
Compare
ofek
approved these changes
Dec 1, 2018
ofek
requested changes
Dec 1, 2018
|
Thanks for this change! When will it be released? |
|
It's going out with 6.8 which should go out next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add pod phase to metrics from KSM with a label join.
Motivation
requested by several users (several support tickets + #2521 + DataDog/datadog-agent#2692)
Review checklist
no-changeloglabel attachedAdditional Notes
I checked the label_joins bit in our codebase, it doesn't break anything. I'm willing to re-evaluate and put it behind an option if someone thinks of something that would break. As usual, if you see something, say something.
Also:
closes #2521