add phase tag label join

DataDog · Nov 21, 2018 · aa4f31e · aa4f31e
1 parent bab268c
commit aa4f31e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py b/datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
@@ -300,6 +300,12 @@ def _store_labels(self, metric, scraper_config):
         if metric.name in scraper_config['label_joins']:
             matching_label = scraper_config['label_joins'][metric.name]['label_to_match']
             for sample in metric.samples:
+                # metadata-only metrics that are used for label joins are always equal to 1
+                # this is required for metrics where all combinations of a state are sent
+                # but only the active one is set to 1 (others are set to 0)
+                # example: kube_pod_status_phase in kube-state-metrics
+                if sample[self.SAMPLE_VALUE] != 1:
+                    continue
                 labels_list = []
                 matching_value = None
                 for label_name, label_value in iteritems(sample[self.SAMPLE_LABELS]):

diff --git a/kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py b/kubernetes_state/datadog_checks/kubernetes_state/kubernetes_state.py
@@ -248,6 +248,10 @@ def _create_kubernetes_state_prometheus_instance(self, instance):
                     'label_to_match': 'pod',
                     'labels_to_get': ['node']
                 },
+                'kube_pod_status_phase': {
+                    'label_to_match': 'pod',
+                    'labels_to_get': ['phase']
+                },
                 'kube_persistentvolume_info': {
                     'label_to_match': 'persistentvolume',
                     'labels_to_get': ['storageclass']