Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate project call and reword os_host config option #2066

Merged
merged 3 commits into from
Aug 17, 2018
Merged

Remove duplicate project call and reword os_host config option #2066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e887dca
Remove duplicate project statement
nmuesch Aug 16, 2018
c546607
Modify language of os_host option
nmuesch Aug 16, 2018
52955de
Modify language of os_host option
nmuesch Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion openstack/datadog_checks/openstack/data/conf.yaml.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ init_config:
# Where your identity server lives. Note that the server must support Identity API v3
keystone_server_url: "https://my-keystone-server.com:<port>/"

# The hostname of this machine registered with Nova. Defaults to socket.gethostname()
# The hostname of this machine registered with Nova.
# Defaults to the Hostname detected by the Agent - https://docs.datadoghq.com/agent/faq/how-datadog-agent-determines-the-hostname/
# os_host: my_hostname

# Nova API version to use - this check supports v2 and v2.1 (default)
Expand Down
4 changes: 0 additions & 4 deletions openstack/datadog_checks/openstack/openstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,10 +1269,6 @@ def check(self, instance):
if set_external_tags is not None:
set_external_tags(self.get_external_host_tags())

if projects:
# Ensure projects list and scoped project exists
self.get_stats_for_all_projects(projects)

except IncompleteConfig as e:
if isinstance(e, IncompleteAuthScope):
self.warning(
Expand Down