Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goroutine_by_scheduling_operation metric to kube_scheduler check #15697

Merged
merged 13 commits into from
Sep 8, 2023
Merged

Add goroutine_by_scheduling_operation metric to kube_scheduler check #15697

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3aaafe6
Add new scheduler_goroutines metric
jennchenn Aug 21, 2023
f6581fb
Rename metric to kube_scheduler.scheduler_goroutines
jennchenn Aug 22, 2023
e7ebada
Add kube_scheduler.scheduler_goroutines metric to metadata
jennchenn Aug 23, 2023
a3fc948
fixup! Add new scheduler_goroutines metric
jennchenn Aug 23, 2023
b2dfb4d
Add simple unit test to verify scheduler_goroutines metric captured p…
jennchenn Aug 23, 2023
243d735
Use raw metrics data as fixture
jennchenn Aug 25, 2023
db3cc50
Unit test metrics for kube v1.26
jennchenn Aug 25, 2023
fb50afd
Add changelog for new metric
jennchenn Aug 25, 2023
ea764ee
Update license header for unit test file
jennchenn Aug 25, 2023
940a0c2
Rename metric to goroutine_by_scheduling_operation for more clarity
jennchenn Aug 29, 2023
b57768e
Specify metric is in alpha
jennchenn Aug 29, 2023
525baf6
Merge branch 'master' into jenn/CONT-3655-add-kube-scheduler-goroutin…
jennchenn Sep 7, 2023
00ec865
Use fixtures and common helper function for tests
jennchenn Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions kube_scheduler/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

***Added***:

* Add goroutine_by_scheduling_operation metric to kube_scheduler check ([#15697](https://github.com/DataDog/integrations-core/pull/15697))

## 4.6.1 / 2023-08-18

***Fixed***:
Expand Down
5 changes: 5 additions & 0 deletions kube_scheduler/datadog_checks/kube_scheduler/kube_scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@
'scheduler_pending_pods': 'pending_pods'
}

NEW_1_26_GAUGES = {
'scheduler_goroutines': 'goroutine_by_scheduling_operation',
}

DEFAULT_GO_METRICS = {
'go_gc_duration_seconds': 'gc_duration_seconds',
'go_goroutines': 'goroutines',
Expand Down Expand Up @@ -159,6 +163,7 @@ def __init__(self, name, init_config, instances):
DEFAULT_GAUGES,
NEW_1_15_GAUGES,
DEFAULT_GO_METRICS,
NEW_1_26_GAUGES,
DEPRECARED_SUMMARIES,
NEW_1_23_HISTOGRAMS,
],
Expand Down
1 change: 1 addition & 0 deletions kube_scheduler/metadata.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ kube_scheduler.gc_duration_seconds.count,gauge,,,,"Number of the GC invocation",
kube_scheduler.gc_duration_seconds.quantile,gauge,,,second,"GC invocation durations quantiles",0,kube_scheduler,goroutines,
kube_scheduler.gc_duration_seconds.sum,gauge,,,second,"GC invocation durations sum",0,kube_scheduler,goroutines,
kube_scheduler.goroutines,gauge,,,,"Number of goroutines that currently exist",0,kube_scheduler,goroutines,
kube_scheduler.goroutine_by_scheduling_operation,gauge,,,,"Number of running goroutines split by the work they do such as binding (requires k8s v1.26+)",0,kube_scheduler,goroutine_by_scheduling_operation,
Copy link
Contributor

@clamoriniere clamoriniere Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also specify in the metric description that this metrics is in alpha stage so they can be removed upstream on the next kubernetes version

I think we have some metric on which we add this info

kube_scheduler.max_fds,gauge,,,,Maximum allowed open file descriptors,0,kube_scheduler,max_fds,
kube_scheduler.open_fds,gauge,,,,Number of open file descriptors,0,kube_scheduler,open_fds,
kube_scheduler.pod_preemption.victims.count,gauge,,,,"Number of selected pods during the latest preemption round",0,kube_scheduler,pod_preemption.victims.count,
Expand Down
Loading