Add goroutine_by_scheduling_operation metric to kube_scheduler check #15697
Conversation
Signed-off-by: Jennifer Chen <jennifer.chen@datadoghq.com>
Signed-off-by: Jennifer Chen <jennifer.chen@datadoghq.com>
Signed-off-by: Jennifer Chen <jennifer.chen@datadoghq.com>
|
The |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Have feedback on the report? Share it here. |
kube_scheduler/metadata.csv
Outdated
| @@ -9,6 +9,7 @@ kube_scheduler.gc_duration_seconds.count,gauge,,,,"Number of the GC invocation", | |||
| kube_scheduler.gc_duration_seconds.quantile,gauge,,,second,"GC invocation durations quantiles",0,kube_scheduler,goroutines, | |||
| kube_scheduler.gc_duration_seconds.sum,gauge,,,second,"GC invocation durations sum",0,kube_scheduler,goroutines, | |||
| kube_scheduler.goroutines,gauge,,,,"Number of goroutines that currently exist",0,kube_scheduler,goroutines, | |||
| kube_scheduler.goroutine_by_scheduling_operation,gauge,,,,"Number of running goroutines split by the work they do such as binding (requires k8s v1.26+)",0,kube_scheduler,goroutine_by_scheduling_operation, | |||
There was a problem hiding this comment.
could you also specify in the metric description that this metrics is in alpha stage so they can be removed upstream on the next kubernetes version
I think we have some metric on which we add this info
| @@ -0,0 +1,132 @@ | |||
| # (C) Datadog, Inc. 2023-present | |||
There was a problem hiding this comment.
The comments I would have here are the same as the ones I have for your other PR
|
/merge |
|
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. You can remove it from the waiting list with you can cancel this operation by commenting your pull request with |
|
/remove |
|
🚂 Devflow: |
|
This merge request was unqueued If you need support, contact us on slack #ci-interfaces! |
What does this PR do?
Add a new metric
kube_scheduler.goroutine_by_scheduling_operationto track the number of running scheduler goroutines split by scheduling operation.Motivation
In Kubernetes v1.26.0, the metric to track the number of running goroutines in the scheduler was renamed to
scheduler_goroutines; the old metric (scheduler_scheduler_goroutines) was deprecated, and removed in Kubernetes v1.28.0. This added metric follows the new naming convention so it can be captured by our users; it is namedkube_scheduler.goroutine_by_scheduling_operationto avoid confusion with thekube_scheduler.goroutinesmetric we already provide.Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.