Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto_conf.yaml template #1523

Merged
merged 3 commits into from
May 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tomcat/auto_conf.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
ad_identifiers:
- tomcat

init_config:
- is_jmx: true
collect_default_metrics: true

instances:
- url: "%%host%%"
port: "9012"
Copy link
Member

@hkaj hkaj May 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this port come from? It's not listed in https://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers - is it considered a de facto standard? Does it work in 90%+ of tomcat setups?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port is also used in the regular tomcat.yaml configuration. But I think the 9012 is the default port tomcat uses for monitoring (https://tomcat.apache.org/tomcat-7.0-doc/monitoring.html)

2 changes: 1 addition & 1 deletion tomcat/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"mac_os",
"windows"
],
"version": "1.0.1",
"version": "1.1.0",
"guid": "60f37d34-3bb7-43c9-9b52-2659b8898997",
"public_title": "Datadog-Tomcat Integration",
"categories":["web", "log collection"],
Expand Down