Update auto_conf.yaml template #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaj
reviewed
May 9, 2018
|
|
||
| instances: | ||
| - url: "%%host%%" | ||
| port: "9012" |
There was a problem hiding this comment.
where does this port come from? It's not listed in https://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers - is it considered a de facto standard? Does it work in 90%+ of tomcat setups?
There was a problem hiding this comment.
The port is also used in the regular tomcat.yaml configuration. But I think the 9012 is the default port tomcat uses for monitoring (https://tomcat.apache.org/tomcat-7.0-doc/monitoring.html)
masci
suggested changes
May 12, 2018
93ad090 to
ebd2856
Compare
masci
suggested changes
May 16, 2018
tomcat/CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # CHANGELOG - tomcat | |||
|
|
|||
| # 1.1.0 / Unreleased | |||
|
|
|||
| * [Update] Update auto_conf template. | |||
There was a problem hiding this comment.
let's remove the entry from the changelog and put this line in the PR title instead
masci
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.jsondatadog_checks/{integration}/__init__.pyCHANGELOG.md. Please useUnreleasedas the date in the titlefor the new section.
Additional Notes
Anything else we should know when reviewing?