Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the 2.3 tests #12723

Closed
wants to merge 2 commits into from
Closed

Re-enable the 2.3 tests #12723

wants to merge 2 commits into from

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Aug 10, 2022 •
edited
Loading

What does this PR do?

The test env for the 2.3 version was disabled. This PR enable it again.

Motivation

This env was disabled because it was flaky (#10141). I would like to re-enable it to see what the errors are and try to fix them if possible.

Part of QA card related to #12595

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@FlorentClarret FlorentClarret requested a review from a team as a code owner August 10, 2022 08:37
jose-manuel-almaza
jose-manuel-almaza reviewed Aug 10, 2022
View reviewed changes
Copy link
Contributor

@jose-manuel-almaza jose-manuel-almaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were disabled?

@FlorentClarret
Copy link
Member Author

Motivation

This env was disabled because it was flaky (#10141). I would like to re-enable it to see what the errors are and try to fix them if possible.
Part of QA card related to #12595

@jose-manuel-almaza ;)

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #12723 (8d6806a) into master (f8f024d) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
harbor 81.54% <ø> (+1.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret
Copy link
Member Author

It's not flaky, it's broken for 2.3+. Closing the PR and I will investigate this after the QA week

@FlorentClarret FlorentClarret deleted the florentclarret/harbor-2.3 branch August 9, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jose-manuel-almaza jose-manuel-almaza jose-manuel-almaza left review comments

Assignees
No one assigned
Labels
changelog/no-changelog integration/harbor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorentClarret @jose-manuel-almaza