Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused or legacy envs, update existing ones #12595

Merged
merged 5 commits into from
Jul 26, 2022
Merged

Remove unused or legacy envs, update existing ones #12595

merged 5 commits into from
Jul 26, 2022

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Jul 26, 2022 •
edited
Loading

This PR:

  • Removes unused envs
  • Removes 1.8 since is no longer referenced in harbor documentation
  • Updates network names to be different between envs since envs were failing to create the networks
  • Updates the docker image versions

@hithwen hithwen requested a review from a team as a code owner July 26, 2022 13:05
@codecov
Copy link

codecov bot commented Jul 26, 2022 •
edited
Loading

Codecov Report

Merging #12595 (cf68a79) into master (941685c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
harbor 80.04% <ø> (-1.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

ofek
ofek approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@hithwen hithwen merged commit 4e3d9b0 into master Jul 26, 2022
@hithwen hithwen deleted the js/harbor-environments branch July 26, 2022 15:47
@FlorentClarret FlorentClarret mentioned this pull request Aug 10, 2022
Closed
4 tasks
@alopezz alopezz mentioned this pull request Aug 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog dev/testing integration/harbor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hithwen @ofek