Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ssl_context documentation #10152

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Remove unused ssl_context documentation #10152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8910993
Remove unused ssl_context documentation
coignetp Sep 17, 2021
b46d793
Sync models
coignetp Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions kafka_consumer/assets/configuration/spec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,6 @@ files:
type: string
example: localhost
display_default: null
- name: ssl_context
description: |
Pre-configured SSLContext for wrapping socket connections.
If provided, all other ssl_* configurations are ignored.
value:
type: string
example: <SSL_CONTEXT>
- name: ssl_check_hostname
description: |
Flag to configure whether SSL handshake should verify that the
Expand Down
4 changes: 0 additions & 4 deletions kafka_consumer/datadog_checks/kafka_consumer/config_models/defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ def instance_ssl_check_hostname(field, value):
return True


def instance_ssl_context(field, value):
return get_default_field_value(field, value)


def instance_ssl_crlfile(field, value):
return get_default_field_value(field, value)

Expand Down
1 change: 0 additions & 1 deletion kafka_consumer/datadog_checks/kafka_consumer/config_models/instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ class Config:
ssl_cafile: Optional[str]
ssl_certfile: Optional[str]
ssl_check_hostname: Optional[bool]
ssl_context: Optional[str]
ssl_crlfile: Optional[str]
ssl_keyfile: Optional[str]
ssl_password: Optional[str]
Expand Down
6 changes: 0 additions & 6 deletions kafka_consumer/datadog_checks/kafka_consumer/data/conf.yaml.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,6 @@ instances:
#
# sasl_kerberos_domain_name: localhost

## @param ssl_context - string - optional
## Pre-configured SSLContext for wrapping socket connections.
## If provided, all other ssl_* configurations are ignored.
#
# ssl_context: <SSL_CONTEXT>

## @param ssl_check_hostname - boolean - optional - default: true
## Flag to configure whether SSL handshake should verify that the
## certificate matches the broker’s hostname.
Expand Down