Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ssl_context documentation #10152

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Sep 17, 2021

What does this PR do?

ssl_context is not used in the kafka_consumer integration.
According to the doc https://kafka-python.readthedocs.io/en/master/apidoc/KafkaClient.html it's a wrapper around options we already support, so we should remove it.

Motivation

Additional Notes

This option does not exist in TlsContextWrapper too, we have a card in the backlog to switch to this wrapper

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #10152 (b46d793) into master (2fccb27) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
kafka_consumer 81.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@coignetp coignetp merged commit 256f652 into master Sep 17, 2021
@coignetp coignetp deleted the paul/kc-remove-context branch September 17, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants