fix: re-introduce k8s 1.18 CI testing #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celenechang
approved these changes
Oct 23, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
|
🚂 MergeQueue: This merge request was already merged This pull request was merged directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update our CI workflow configuration and add back CI chart testing with kubernetes v1.18.x.
Since #1486 the CI job was failing on the chart testing with kubernetes
v1.18. To keep our capability to merge PRs, we commented the testing for 1.18 in #1576.After investigation we understood the issue: #1486 has pumped the kind-action from
v1.5.0tov1.10.0which pumps the kind-action version fromv0.17.0tov0.22.0. However, kindv0.22.0is not able anymore to start the node imagev1.18.To solve the issue we now express which kind version needs to be used with each kubernetes version. So we can reintroduce the charts testing on kubernetes cluster
v1.18.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
the draft PR #1580 is here to test that with this change the chart validation is able to run test on 1.18 cluster
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdmake update-test-baselines)