Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove k8s 1.18.20 from testing matrix #1576

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

tbavelier
Copy link
Member

@tbavelier tbavelier commented Oct 23, 2024

What this PR does / why we need it:

╰─❯ kind create cluster --config .github/kind_config.yaml --name chart-testing --wait 60s --image kindest/node:v1.18.20
Creating cluster "chart-testing" ...
 ✓ Ensuring node image (kindest/node:v1.18.20) 🖼
 ✓ Preparing nodes 📦 📦
 ✓ Writing configuration 📜
 ✗ Starting control-plane 🕹️
Deleted nodes: ["chart-testing-worker" "chart-testing-control-plane"]
ERROR: failed to create cluster: failed to init node with kubeadm: command "docker exec --privileged chart-testing-control-plane kubeadm init --config=/kind/kubeadm.conf --skip-token-print --v=6 --skip-phases=preflight" failed with error: exit status 1

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@tbavelier tbavelier added chart/datadog This issue or pull request is related to the datadog chart tools/ci labels Oct 23, 2024
@tbavelier tbavelier marked this pull request as ready for review October 23, 2024 09:42
@tbavelier tbavelier requested a review from a team as a code owner October 23, 2024 09:42
@clamoriniere
Copy link
Collaborator

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 23, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 36m.

Use /merge -c to cancel this operation!

@davidor
Copy link
Member

davidor commented Oct 23, 2024

Is this just because 1.18.20 is no longer available in the kind version that we're using now or something else?

@tbavelier
Copy link
Member Author

Is this just because 1.18.20 is no longer available in the kind version that we're using now or something else?

@clamoriniere will own the investigation/fix, but seems likely.

@tbavelier tbavelier merged commit 0d8e6f6 into main Oct 23, 2024
4 checks passed
@tbavelier tbavelier deleted the tbavelier/fix_ci branch October 23, 2024 11:32
@dd-devflow
Copy link

dd-devflow bot commented Oct 23, 2024

🚂 MergeQueue: This merge request was already merged

This pull request was merged directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart mergequeue-status: done tools/ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants