Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete rm '/agent/conf.d/network.yaml.default' in docker files #184

Closed
wants to merge 1 commit into from

Conversation

dturn
Copy link

@dturn dturn commented Mar 22, 2017

What does this PR do?

Small fix to make the docker images build. '/agent/conf.d/network.yaml.default' was removed in DataDog/dd-agent@b74d12f so it can't be deleted:

DataDog/dd-agent@5.11.0...5.12.0

Motivation

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Additional Notes

Anything else we should know when reviewing?

@dturn
Copy link
Author

dturn commented Mar 22, 2017

I'm wondering if I'm missing the bigger picture here. Doing some local testing, I've had to add mkdir $DD_HOME/agent/checks.d to get the collector to function correctly.

@hkaj
Copy link
Member

hkaj commented Mar 23, 2017

Hi @dturn thanks for reacting so promptly!
We'll use #185 for caution (in case someone uses the dockerfile and only replaces the agent version env var). The other issue you mentioned is fixed by DataDog/dd-agent#3281 which will go out with the next bug fix release.

Thanks again!

@hkaj hkaj closed this Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants