Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the 5.12.0 Source Install #3281

Merged
merged 4 commits into from
Mar 23, 2017
Merged

Conversation

gmmeyer
Copy link
Contributor

@gmmeyer gmmeyer commented Mar 23, 2017

What does this PR do?

Fixes the source install, which failed when we removed all the checks from the agent. It was partially integrated, but did not entirely work.

print_console "* Trying to install integration requirements"
for INT_DIR in "$DD_HOME/integrations/*"; do
print_console "* Setting up integrations"
INTEGRATIONS=$(ls $DD_HOME/integrations/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you want want is INTEGRATIONS=$(ls -d $DD_HOME/integrations/*)

Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, just tested it locally. I saw you decided to keep the integrations dir around. Do we not want to remove it after copying the checks over to checks.d?

@truthbk truthbk merged commit 1445662 into master Mar 23, 2017
@gmmeyer
Copy link
Contributor Author

gmmeyer commented Mar 23, 2017

I think we should remove it, for some reason it seemed to cause a bug when I did. I will investigate but better to get this out than spend time on that.

gmmeyer added a commit that referenced this pull request Mar 23, 2017
* fixes source install

* removes integrations dir

* fixes integrations

* fixes the indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants