Use latest mysql2 version for testing #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ce51b5 to
9d9bc24
Compare
|
As discussed with @delner, unlocked the library version a little more, to |
delner
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we locked
mysql2 < 0.5in #382, the Rails team has released (and backported) a fix that allows us to use the newest version ofmysql2(currently0.5.2).Support for this new version of
mysql2starts with Rails 4.2 (using an updated patch release).This PR updates
dd-trace-rbtest matrix to test againstmysql2 < 1; keeping the version somewhat conservative, in case a bump to1.0breaks ActiveRecord again.