Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin mysql2 < 0.5.0 to prevent CI build from breaking #382

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Pin mysql2 < 0.5.0 to prevent CI build from breaking #382

merged 1 commit into from
Mar 22, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Mar 21, 2018

mysql2 version 0.5.0 was released yesterday, and following in ActiveRecord tradition, new adapter versions break ActiveRecord, which in turn is breaking our CI build.

This pull request pins the gem version to < 0.5.0, until the Rails guys fix the issue. See rails/rails#32310.

@delner delner added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Mar 21, 2018
@delner delner self-assigned this Mar 21, 2018
@delner delner requested review from p-lambert and palazzem March 21, 2018 21:19
@palazzem palazzem added this to the 0.12.0 milestone Mar 22, 2018
palazzem
palazzem approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me. Anyway, we should start writing a better matrix because we don't have a clear list of supported versions (made exception of web frameworks).

Let's start working on it after our 0.12.0 release.

@palazzem palazzem merged commit 4e900ad into master Mar 22, 2018
@palazzem palazzem deleted the ci/pin_mysql2_below_0.5.0 branch March 22, 2018 15:37
@delner delner mentioned this pull request Mar 22, 2018
Closed
@delner delner modified the milestones: 0.12.0, 0.11.4 Mar 28, 2018
@marcotc marcotc mentioned this pull request Sep 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

@p-lambert p-lambert Awaiting requested review from p-lambert

Assignees

@delner delner

Labels
dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Milestone
0.11.4
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @palazzem