Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[APPSEC-56614] Add Instrumentation::Gateway#pushed? method" #4465

Conversation

sarahchen6
Copy link
Contributor

Reverts #4459 to finish the 2.12.1 release. Will merge back in after the release is complete.

@sarahchen6 sarahchen6 requested a review from a team as a code owner March 6, 2025 13:21
Copy link

github-actions bot commented Mar 6, 2025

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-03-06 13:21:39 UTC

@github-actions github-actions bot added the appsec Application Security monitoring product label Mar 6, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (e721aba) to head (53872f8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4465      +/-   ##
==========================================
- Coverage   97.69%   97.69%   -0.01%     
==========================================
  Files        1376     1375       -1     
  Lines       83825    83812      -13     
  Branches     4251     4251              
==========================================
- Hits        81890    81877      -13     
  Misses       1935     1935              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: revert-4459-appsec-56614-track-triggered-instrumentation-events
Commit report: 53872f8
Test service: dd-trace-rb

✅ 0 Failed, 20624 Passed, 1370 Skipped, 3m 14.14s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 6, 2025

Benchmarks

Benchmark execution time: 2025-03-06 13:44:05

Comparing candidate commit 53872f8 in PR branch revert-4459-appsec-56614-track-triggered-instrumentation-events with baseline commit e721aba in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@sarahchen6 sarahchen6 requested a review from Strech March 6, 2025 13:46
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@sarahchen6 sarahchen6 merged commit 07e95b4 into master Mar 6, 2025
482 checks passed
@sarahchen6 sarahchen6 deleted the revert-4459-appsec-56614-track-triggered-instrumentation-events branch March 6, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants