Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPSEC-56614] Add Instrumentation::Gateway#pushed? method #4459

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

Strech
Copy link
Member

@Strech Strech commented Mar 5, 2025

What does this PR do?

Adds a method to check wether event with specific name was already ever pushed or not

Motivation:

I need a way to react on one event only if another event was pushed before. To make it very straightforward I decided to allow a simple check - was an event published or not.

Change log entry

No. Internal change

Additional Notes:

The whole Instrumentation::Gateway is a subject to rewrite, but the core logic of "I want to know about what kind of events were pushed" remains.

How to test the change?

CI is good enough.

@github-actions github-actions bot added the appsec Application Security monitoring product label Mar 5, 2025
@Strech Strech force-pushed the appsec-56614-track-triggered-instrumentation-events branch from a9e8aff to 85396a7 Compare March 5, 2025 13:35
@Strech Strech added the dev/internal Other internal work that does not need to be included in the changelog label Mar 5, 2025
@Strech Strech marked this pull request as ready for review March 5, 2025 13:40
@Strech Strech requested a review from a team as a code owner March 5, 2025 13:40
@pr-commenter
Copy link

pr-commenter bot commented Mar 5, 2025

Benchmarks

Benchmark execution time: 2025-03-06 10:32:20

Comparing candidate commit 241d169 in PR branch appsec-56614-track-triggered-instrumentation-events with baseline commit 2f427f8 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - Allocations ()

  • 🟩 throughput [+195396.272op/s; +213426.359op/s] or [+6.278%; +6.857%]

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (2f427f8) to head (241d169).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4459      +/-   ##
==========================================
- Coverage   97.70%   97.69%   -0.01%     
==========================================
  Files        1375     1376       +1     
  Lines       83812    83824      +12     
  Branches     4251     4251              
==========================================
+ Hits        81887    81894       +7     
- Misses       1925     1930       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 5, 2025

Datadog Report

Branch report: appsec-56614-track-triggered-instrumentation-events
Commit report: 241d169
Test service: dd-trace-rb

✅ 0 Failed, 20623 Passed, 1374 Skipped, 3m 12.93s Total Time

@Strech Strech force-pushed the appsec-56614-track-triggered-instrumentation-events branch from a03d0c6 to 241d169 Compare March 6, 2025 10:08
@Strech Strech enabled auto-merge March 6, 2025 10:21
@Strech Strech disabled auto-merge March 6, 2025 11:08
@Strech Strech enabled auto-merge March 6, 2025 12:47
@Strech Strech merged commit e721aba into master Mar 6, 2025
481 checks passed
@Strech Strech deleted the appsec-56614-track-triggered-instrumentation-events branch March 6, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants