-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APPSEC-56614] Add Instrumentation::Gateway#pushed? method #4459
[APPSEC-56614] Add Instrumentation::Gateway#pushed? method #4459
Conversation
a9e8aff
to
85396a7
Compare
BenchmarksBenchmark execution time: 2025-03-06 10:32:20 Comparing candidate commit 241d169 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - Allocations ()
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4459 +/- ##
==========================================
- Coverage 97.70% 97.69% -0.01%
==========================================
Files 1375 1376 +1
Lines 83812 83824 +12
Branches 4251 4251
==========================================
+ Hits 81887 81894 +7
- Misses 1925 1930 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 20623 Passed, 1374 Skipped, 3m 12.93s Total Time |
a03d0c6
to
241d169
Compare
What does this PR do?
Adds a method to check wether event with specific name was already ever pushed or not
Motivation:
I need a way to react on one event only if another event was pushed before. To make it very straightforward I decided to allow a simple check - was an event published or not.
Change log entry
No. Internal change
Additional Notes:
The whole
Instrumentation::Gateway
is a subject to rewrite, but the core logic of "I want to know about what kind of events were pushed" remains.How to test the change?
CI is good enough.