Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove missing file from Steepfile. #4447

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

sarahchen6
Copy link
Contributor

What does this PR do?
Removes the missing ignored file from #4439.

Motivation:
Keep our Steepfile updated.

Change log entry
None.

Additional Notes:

How to test the change?
Confirm file does not exist. #4439 rebased on this branch will no longer emit a warning for the missing file.

@sarahchen6 sarahchen6 requested a review from a team as a code owner February 28, 2025 17:50
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (987b7a6) to head (b9ecf7c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4447      +/-   ##
==========================================
- Coverage   97.70%   97.68%   -0.02%     
==========================================
  Files        1374     1374              
  Lines       83807    83806       -1     
  Branches     4249     4249              
==========================================
- Hits        81881    81869      -12     
- Misses       1926     1937      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: sarahchen6/remove-missing-file-from-steepfile
Commit report: b9ecf7c
Test service: dd-trace-rb

✅ 0 Failed, 20614 Passed, 1459 Skipped, 3m 20.09s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2025

Benchmarks

Benchmark execution time: 2025-02-28 18:11:04

Comparing candidate commit b9ecf7c in PR branch sarahchen6/remove-missing-file-from-steepfile with baseline commit 987b7a6 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - profiler gc

  • 🟥 throughput [-22154.648op/s; -21030.895op/s] or [-7.236%; -6.869%]

@sarahchen6 sarahchen6 merged commit a574273 into master Mar 3, 2025
274 checks passed
@sarahchen6 sarahchen6 deleted the sarahchen6/remove-missing-file-from-steepfile branch March 3, 2025 15:03
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 3, 2025
@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants