Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignored files to GHA steep summary. #4439

Merged
merged 8 commits into from
Mar 12, 2025

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Feb 26, 2025

What does this PR do?
Add ignored files from Steepfile into our GHA steep/typecheck summary. Here is an example of a steep/typecheck summary.

Motivation:
We have a lot of files that are ignored by steep type-checking, so this will provide visibility in our summary of which files are ignored.

Change log entry
None.

Additional Notes:

How to test the change?
See the ignored files in the GHA steep/typecheck summary for this PR.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 26, 2025

Datadog Report

Branch report: sarahchen6/add-ignored-files-to-steep-summary
Commit report: 0b29186
Test service: dd-trace-rb

✅ 0 Failed, 20611 Passed, 1373 Skipped, 3m 21.14s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (fa88415) to head (0b29186).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4439      +/-   ##
==========================================
- Coverage   97.71%   97.69%   -0.02%     
==========================================
  Files        1374     1374              
  Lines       83755    83806      +51     
  Branches     4236     4249      +13     
==========================================
+ Hits        81841    81877      +36     
- Misses       1914     1929      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ignored-files-to-steep-summary branch from cabc0b5 to dc50bac Compare February 26, 2025 20:50
@pr-commenter
Copy link

pr-commenter bot commented Feb 26, 2025

Benchmarks

Benchmark execution time: 2025-02-28 17:09:06

Comparing candidate commit 0b29186 in PR branch sarahchen6/add-ignored-files-to-steep-summary with baseline commit fa88415 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@sarahchen6 sarahchen6 changed the title [TEST] Add ignored files to GHA steep summary. Add ignored files to GHA steep summary. Feb 26, 2025
@sarahchen6 sarahchen6 marked this pull request as ready for review February 27, 2025 18:55
@sarahchen6 sarahchen6 requested a review from a team as a code owner February 27, 2025 18:55
@sarahchen6 sarahchen6 requested a review from lloeki February 27, 2025 18:55
@sarahchen6 sarahchen6 requested review from Strech and lloeki February 28, 2025 13:56
@p-datadog
Copy link
Member

If a file is given in steepfile but does not exist on the filesystem, will it be shown in the report?

@sarahchen6
Copy link
Contributor Author

sarahchen6 commented Feb 28, 2025

If a file is given in steepfile but does not exist on the filesystem, will it be shown in the report?

It will be shown in the report, but that's a good situation to highlight. Just added - If the file does not exist in the filesystem, then a warning about the missing file and a recommendation to remove it from Steepfile is given, instead of it being added to the report.

@sarahchen6 sarahchen6 force-pushed the sarahchen6/add-ignored-files-to-steep-summary branch from 1f6b3f5 to 0b29186 Compare February 28, 2025 16:45
Copy link
Member

@lloeki lloeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@sarahchen6 sarahchen6 merged commit 1a7d17e into master Mar 12, 2025
479 checks passed
@sarahchen6 sarahchen6 deleted the sarahchen6/add-ignored-files-to-steep-summary branch March 12, 2025 12:53
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants