-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignored files to GHA steep summary. #4439
Add ignored files to GHA steep summary. #4439
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 20611 Passed, 1373 Skipped, 3m 21.14s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4439 +/- ##
==========================================
- Coverage 97.71% 97.69% -0.02%
==========================================
Files 1374 1374
Lines 83755 83806 +51
Branches 4236 4249 +13
==========================================
+ Hits 81841 81877 +36
- Misses 1914 1929 +15 ☔ View full report in Codecov by Sentry. |
cabc0b5
to
dc50bac
Compare
BenchmarksBenchmark execution time: 2025-02-28 17:09:06 Comparing candidate commit 0b29186 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
If a file is given in steepfile but does not exist on the filesystem, will it be shown in the report? |
It will be shown in the report, but that's a good situation to highlight. Just added - If the file does not exist in the filesystem, then a warning about the missing file and a recommendation to remove it from |
1f6b3f5
to
0b29186
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
What does this PR do?
Add ignored files from
Steepfile
into our GHA steep/typecheck summary. Here is an example of a steep/typecheck summary.Motivation:
We have a lot of files that are ignored by steep type-checking, so this will provide visibility in our summary of which files are ignored.
Change log entry
None.
Additional Notes:
How to test the change?
See the ignored files in the GHA
steep/typecheck summary
for this PR.