DEBUG-3249 remove usage of OpenStruct in DI #4274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for updating Change log entry section 👏 Visited at: 2025-01-09 23:56:20 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 22124 Passed, 1477 Skipped, 5m 2.3s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4274 +/- ##
==========================================
- Coverage 97.72% 97.71% -0.02%
==========================================
Files 1354 1354
Lines 82418 82421 +3
Branches 4220 4220
==========================================
- Hits 80544 80538 -6
- Misses 1874 1883 +9 ☔ View full report in Codecov by Sentry. |
ivoanjo
requested changes
Jan 10, 2025
ivoanjo
approved these changes
Jan 10, 2025
* master: [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/12712388067 Align simplcov version usage Instructions for running integration tests (#4260) Fix another checksum [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/12711409236 Move rubocop group [NO-TICKET] Disable flaky barrier spec Remove obsolete code from gateway watchers reduce the matrix reduce matrix skiping k8s profiling for ruby test needs k8s add 7.57.0 reduce the matrix new k8s scenarios added K8s lib injection tests new scenarios
marcotc
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes usage of OpenStruct in dynamic instrumentation.
Adds
ostructas dependency for:testgroup, since OpenStruct is used in the test suite.Removes
ostructdependency in all groups as added in #4271.Motivation:
Fixing the
ostructwarning produced by rubygemsChange log entry
None
Additional Notes:
I added explicit requires of
ostructto tests that use it.How to test the change?