[NO-TICKET] Enable typechecking more files #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR enables typechecking for a lot more files that it turns out are already passing typechecks. Many of these files we only have skeleton types that still need to be improved, so this is a small win, but it was a quite cheap one so I thought it was worth doing. **Motivation:** I noticed that we had at least one file that was passing typecheck, but still ignored. This sparked my curiosity, and with a bit of scripting I got a huge list of files that we could enable typechecking for already :) **Additional Notes:** N/A **How to test the change?** Validate that `bundle exec steep check` still passes!
|
Thank you for updating Change log entry section 👏 Visited at: 2025-01-09 20:12:29 UTC |
This is needed to unblock the test-asan check. I'm working with upstream ( ruby/setup-ruby#682 ) to see if we can get an asan build based off a stable Ruby to avoid the "flakiness" of testing with a Ruby based on ruby-head.
Datadog ReportBranch report: ✅ 0 Failed, 22117 Passed, 1475 Skipped, 5m 12.64s Total Time |
BenchmarksBenchmark execution time: 2025-01-09 20:41:47 Comparing candidate commit de276c7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
marcotc
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables typechecking for a lot more files that it turns out are already passing typechecks.
Many of these files we only have skeleton types that still need to be improved, so this is a small win, but it was a quite cheap one so I thought it was worth doing.
Motivation:
I noticed that we had at least one file that was passing typecheck, but still ignored. This sparked my curiosity, and with a bit of scripting I got a huge list of files that we could enable typechecking for already :)
Change log entry
None
Additional Notes:
N/A
How to test the change?
Validate that
bundle exec steep checkstill passes!