-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appsec.blocked tag to span #2895
Conversation
27ae1a7
to
2034a37
Compare
deb8eb8
to
576335d
Compare
576335d
to
17b4d92
Compare
Codecov Report
@@ Coverage Diff @@
## master #2895 +/- ##
==========================================
- Coverage 98.10% 98.09% -0.02%
==========================================
Files 1266 1267 +1
Lines 70140 70000 -140
Branches 3186 3194 +8
==========================================
- Hits 68813 68664 -149
- Misses 1327 1336 +9 see 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, save for a bit about naming that would bring confusion to future readers.
What does this PR do?
Make sure to add the
appsec.blocked
at the span when the request has been blocked.The main change is on the different watcher files:
The line
span.set_tag('appsec.blocked', 'true') if result.actions.include?('block')
is the one adding the tag.The rest of the changes are improving the codebase:
Event.build_service_entry_tags
helper method to reduce the size ofEvent.record_via_span
Motivation
Make sure our code is up to date with RFCs and system tests
Additional Notes
How to test the change?
CI