Add spec to validate appsec.blocked tag present

DataDog · Jun 5, 2023 · 27ae1a7 · 27ae1a7
1 parent 04e6ef0
commit 27ae1a7
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 19 deletions.
diff --git a/spec/datadog/appsec/contrib/rack/integration_test_spec.rb b/spec/datadog/appsec/contrib/rack/integration_test_spec.rb
@@ -260,7 +260,7 @@
 
             it_behaves_like 'a GET 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
 
@@ -295,7 +295,7 @@
 
             it_behaves_like 'a GET 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
 
@@ -315,7 +315,7 @@
 
             it_behaves_like 'a GET 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
       end
@@ -360,7 +360,7 @@
 
             it_behaves_like 'a POST 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
 
@@ -390,7 +390,7 @@
 
               it_behaves_like 'a POST 403 span'
               it_behaves_like 'a trace with AppSec tags'
-              it_behaves_like 'a trace with AppSec events'
+              it_behaves_like 'a trace with AppSec events', { blocking: true }
             end
           end
         end
@@ -430,7 +430,7 @@
 
             it_behaves_like 'a POST 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
       end

diff --git a/spec/datadog/appsec/contrib/rails/integration_test_spec.rb b/spec/datadog/appsec/contrib/rails/integration_test_spec.rb
@@ -211,7 +211,7 @@ def set_user
 
             it_behaves_like 'a GET 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
 
@@ -237,7 +237,7 @@ def set_user
 
             it_behaves_like 'a GET 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
 
@@ -250,7 +250,7 @@ def set_user
 
           it_behaves_like 'a GET 403 span'
           it_behaves_like 'a trace with AppSec tags'
-          it_behaves_like 'a trace with AppSec events'
+          it_behaves_like 'a trace with AppSec events', { blocking: true }
         end
 
         context 'with an event-triggering response' do
@@ -317,7 +317,7 @@ def set_user
 
             it_behaves_like 'a POST 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
 
@@ -339,7 +339,7 @@ def set_user
 
               it_behaves_like 'a POST 403 span'
               it_behaves_like 'a trace with AppSec tags'
-              it_behaves_like 'a trace with AppSec events'
+              it_behaves_like 'a trace with AppSec events', { blocking: true }
             end
           end
         end
@@ -361,7 +361,7 @@ def set_user
 
             it_behaves_like 'a POST 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
       end
@@ -435,7 +435,7 @@ def set_user
 
               it_behaves_like 'a GET 403 span'
               it_behaves_like 'a trace with AppSec tags'
-              it_behaves_like 'a trace with AppSec events'
+              it_behaves_like 'a trace with AppSec events', { blocking: true }
             end
           end
         end

diff --git a/spec/datadog/appsec/contrib/sinatra/integration_test_spec.rb b/spec/datadog/appsec/contrib/sinatra/integration_test_spec.rb
@@ -215,7 +215,7 @@
 
             it_behaves_like 'a GET 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
 
@@ -243,7 +243,7 @@
 
             it_behaves_like 'a GET 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
 
@@ -256,7 +256,7 @@
 
           it_behaves_like 'a GET 403 span'
           it_behaves_like 'a trace with AppSec tags'
-          it_behaves_like 'a trace with AppSec events'
+          it_behaves_like 'a trace with AppSec events', { blocking: true }
         end
 
         context 'with an event-triggering response' do
@@ -286,7 +286,7 @@
 
             it_behaves_like 'a GET 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
       end
@@ -323,7 +323,7 @@
 
             it_behaves_like 'a POST 403 span'
             it_behaves_like 'a trace with AppSec tags'
-            it_behaves_like 'a trace with AppSec events'
+            it_behaves_like 'a trace with AppSec events', { blocking: true }
           end
         end
 

diff --git a/spec/datadog/appsec/contrib/support/integration/shared_examples.rb b/spec/datadog/appsec/contrib/support/integration/shared_examples.rb
@@ -119,10 +119,13 @@
   end
 end
 
-RSpec.shared_examples 'a trace with AppSec events' do
+RSpec.shared_examples 'a trace with AppSec events' do |params = { blocking: false }|
+  let(:blocking_request) { params[:blocking] }
+
   it do
     expect(spans.select { |s| s.get_tag('appsec.event') }).to_not be_empty
     expect(service_span.send(:meta)['_dd.appsec.json']).to be_a String
+    expect(spans.select { |s| s.get_tag('appsec.blocked') }).to_not be_empty if blocking_request
   end
 
   context 'with appsec disabled' do