Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[core] SpooledTemporaryFile for subprocess output" #3291

Merged
merged 2 commits into from
Mar 30, 2017
Merged

Revert "[core] SpooledTemporaryFile for subprocess output" #3291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
801e0e5
Revert "[core] SpooledTemporaryFile for subprocess output"
degemer Feb 6, 2017
54a2999
[utils/subprocess] bring back syntax improvements
degemer Mar 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions utils/subprocess_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,10 @@ def get_subprocess_output(command, log, raise_on_empty_output=True):
if an error occurs.
"""

max_size = 1024 * 1024 # 1 MB

with tempfile.SpooledTemporaryFile(max_size=max_size) as stdout_f, tempfile.SpooledTemporaryFile(max_size=max_size) as stderr_f:
# Use tempfile, allowing a larger amount of memory. The subprocess.Popen
# docs warn that the data read is buffered in memory. They suggest not to
# use subprocess.PIPE if the data size is large or unlimited.
with tempfile.TemporaryFile() as stdout_f, tempfile.TemporaryFile() as stderr_f:
proc = subprocess.Popen(command, stdout=stdout_f, stderr=stderr_f)
proc.wait()
stderr_f.seek(0)
Expand Down