Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[core] SpooledTemporaryFile for subprocess output" #3291

Merged
merged 2 commits into from
Mar 30, 2017
Merged

Revert "[core] SpooledTemporaryFile for subprocess output" #3291

merged 2 commits into from
Mar 30, 2017

Conversation

degemer
Copy link
Member

@degemer degemer commented Mar 29, 2017

Reverts #3002

Unfortunately, SpooledTemporaryFile and TemporaryFile behave the same in this case, because subprocess.Popen needs actual files.

Let's revert to avoid confusing people.

@degemer degemer added this to the 5.13.0 milestone Mar 29, 2017
@degemer degemer requested a review from olivielpeau March 29, 2017 21:14
@degemer
[utils/subprocess] bring back syntax improvements
54a2999 
Needlessly reverted by the previous commit.
@degemer degemer force-pushed the revert-3002-quentin/subprocess-output-in-memory branch from 8721695 to 54a2999 Compare March 29, 2017 22:13
@degemer degemer merged commit a759e98 into master Mar 30, 2017
@degemer degemer deleted the revert-3002-quentin/subprocess-output-in-memory branch March 30, 2017 14:01
@masci masci modified the milestones: 5.13.0, 5.14.x Apr 12, 2017
@truthbk truthbk modified the milestones: 5.13.0, 5.14 Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivielpeau olivielpeau olivielpeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@degemer @olivielpeau @masci @truthbk