[podman] Change sqlite backend

[davidor]

What does this PR do?

Changes the SQLite backend used by Podman from modernc.org/sqlite to github.com/mattn/go-sqlite3.

Reasons for the Change:

• Alignment with Podman upstream: When this functionality was introduced, modernc.org/sqlite was chosen due to unrelated integration test failures. However, those issues no longer exist, so switching to go-sqlite3 ensures consistency with the upstream implementation. More details can be found in this PR: [Podman] Supports SQLite containers database back-end to support newer versions (4.8+) #24373.
• Reduction in binary size ([podman] Change sqlite backend #34358 (comment)): This change reduces the binary size in the dogstatsd binary. However, the impact is less noticeable for the agents because some Trivy-related code in the Core Agent still depends on modernc.org/sqlite.

The part of the code that uses this is not highly performance-sensitive, as it only executes a simple query to retrieve the pods on a node, so changing the library shouldn't really change much.

Describe how you validated your changes

I ran the agent in a version of Podman that uses SQLite and followed the instructions in the original PR: #24373

We don't have e2e tests for Podman, so I'll mark this to be tested during QA.

[cit-pr-commenter]

Go Package Import Differences

Baseline: f146db9
Comparison: 8be3c7a

binary	os	arch	change
agent	linux	amd64	+1, -0 +github.com/mattn/go-sqlite3
agent	linux	arm64	+1, -0 +github.com/mattn/go-sqlite3
dogstatsd	linux	amd64	+1, -8 +github.com/mattn/go-sqlite3 -github.com/remyoudompheng/bigfft -modernc.org/libc -modernc.org/libc/sys/types -modernc.org/libc/uuid/uuid -modernc.org/mathutil -modernc.org/memory -modernc.org/sqlite -modernc.org/sqlite/lib
dogstatsd	linux	arm64	+1, -8 +github.com/mattn/go-sqlite3 -github.com/remyoudompheng/bigfft -modernc.org/libc -modernc.org/libc/sys/types -modernc.org/libc/uuid/uuid -modernc.org/mathutil -modernc.org/memory -modernc.org/sqlite -modernc.org/sqlite/lib
process-agent	linux	amd64	+1, -8 +github.com/mattn/go-sqlite3 -github.com/remyoudompheng/bigfft -modernc.org/libc -modernc.org/libc/sys/types -modernc.org/libc/uuid/uuid -modernc.org/mathutil -modernc.org/memory -modernc.org/sqlite -modernc.org/sqlite/lib
process-agent	linux	arm64	+1, -8 +github.com/mattn/go-sqlite3 -github.com/remyoudompheng/bigfft -modernc.org/libc -modernc.org/libc/sys/types -modernc.org/libc/uuid/uuid -modernc.org/mathutil -modernc.org/memory -modernc.org/sqlite -modernc.org/sqlite/lib

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=56740171 --os-family=ubuntu

Note: This applies to commit 8be3c7a

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor f146db91a35801a3d6210d70962a2e76b7c2f717

Diff per package

package	diff	status	size	ancestor	threshold
datadog-heroku-agent-amd64-deb	0.00MB	✅	443.42MB	443.42MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	62.03MB	62.03MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	62.10MB	62.10MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	62.10MB	62.10MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.27MB	59.27MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.34MB	59.34MB	0.50MB
datadog-agent-arm64-deb	-0.12MB	✅	848.79MB	848.91MB	0.50MB
datadog-agent-aarch64-rpm	-0.12MB	✅	858.54MB	858.66MB	0.50MB
datadog-agent-x86_64-rpm	-0.41MB	✅	868.95MB	869.36MB	0.50MB
datadog-agent-x86_64-suse	-0.41MB	✅	868.95MB	869.36MB	0.50MB
datadog-agent-amd64-deb	-0.41MB	✅	859.18MB	859.59MB	0.50MB
datadog-dogstatsd-arm64-deb	-1.70MB	✅	37.97MB	39.67MB	0.50MB
datadog-dogstatsd-amd64-deb	-1.99MB	✅	39.42MB	41.41MB	0.50MB
datadog-dogstatsd-x86_64-rpm	-1.99MB	✅	39.50MB	41.49MB	0.50MB
datadog-dogstatsd-x86_64-suse	-1.99MB	✅	39.50MB	41.49MB	0.50MB

Decision

✅ Passed

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	830.65MiB	847.49MiB	201.36MiB	212.33MiB
✅	static_quality_gate_agent_deb_arm64	820.72MiB	836.66MiB	181.69MiB	192.5MiB
✅	static_quality_gate_agent_rpm_amd64	830.64MiB	847.82MiB	204.2MiB	215.76MiB
✅	static_quality_gate_agent_rpm_arm64	820.71MiB	836.66MiB	183.68MiB	194.24MiB
✅	static_quality_gate_agent_suse_amd64	830.64MiB	847.82MiB	204.2MiB	215.76MiB
✅	static_quality_gate_agent_suse_arm64	820.71MiB	836.66MiB	183.68MiB	194.24MiB
✅	static_quality_gate_dogstatsd_deb_amd64	37.67MiB	49.7MiB	9.78MiB	20.6MiB
✅	static_quality_gate_dogstatsd_deb_arm64	36.28MiB	48.1MiB	8.49MiB	19.1MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	37.67MiB	49.7MiB	9.79MiB	20.6MiB
✅	static_quality_gate_dogstatsd_suse_amd64	37.67MiB	49.7MiB	9.79MiB	20.6MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.23MiB	69.0MiB	14.88MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.59MiB	66.4MiB	12.83MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.59MiB	66.4MiB	12.85MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.23MiB	69.0MiB	14.9MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	915.5MiB	931.7MiB	307.08MiB	318.67MiB
✅	static_quality_gate_docker_agent_arm64	928.86MiB	944.08MiB	292.13MiB	303.0MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.09GiB	1.1GiB	382.16MiB	393.75MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.09GiB	1.1GiB	363.21MiB	373.71MiB
✅	static_quality_gate_docker_dogstatsd_amd64	45.82MiB	57.88MiB	17.28MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	44.45MiB	56.27MiB	16.16MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.95MiB	274.78MiB	106.33MiB	116.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.92MiB	290.82MiB	101.18MiB	111.12MiB

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 709d884f-e0f6-493a-8b83-6f95d3e80f4a

Baseline: f146db9
Comparison: 8be3c7a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+0.66	[+0.60, +0.73]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.16	[-0.61, +0.94]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.12	[-0.34, +0.58]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.68, +0.74]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.01	[-0.76, +0.78]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.03, +0.02]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.64, +0.63]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.01	[-0.87, +0.84]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.30, +0.26]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.02	[-0.79, +0.75]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.02	[-0.87, +0.82]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.32	[-1.27, +0.62]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.44	[-3.47, +2.58]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.73	[-0.77, -0.68]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	-0.85	[-0.91, -0.79]	1	Logs
➖	quality_gate_idle	memory utilization	-1.13	[-1.18, -1.07]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[davidor]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.
2025-02-24 14:43:07 UTC ℹ️ Start processing command /merge

---

2025-02-24 14:43:12 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.

---

2025-02-24 15:12:22 UTC ℹ️ MergeQueue: This merge request was merged